Add ContentSuggestionsService to SnippetsInternals

chrome/browser/resources/snippets_internals.js

Index: chrome/browser/resources/snippets_internals.js
diff --git a/chrome/browser/resources/snippets_internals.js b/chrome/browser/resources/snippets_internals.js
index b44905c2733359c1f4844acdc4d86eefd9ff411d..c8a3593078939809ad3d60e17e0971d15a4bfe35 100644
--- a/chrome/browser/resources/snippets_internals.js
+++ b/chrome/browser/resources/snippets_internals.js
@@ -38,6 +38,18 @@ cr.define('chrome.SnippetsInternals', function() {
       event.preventDefault();
     });
 
+    $('submit-clear-cached-suggestions')
+        .addEventListener('click', function(event) {
+      chrome.send('clearCachedSuggestions');
+      event.preventDefault();
+    });
+
+    $('submit-clear-discarded-suggestions')
+        .addEventListener('click', function(event) {
+      chrome.send('clearDiscardedSuggestions');
+      event.preventDefault();
+    });
+
     chrome.send('loaded');
   }
 
@@ -69,6 +81,11 @@ cr.define('chrome.SnippetsInternals', function() {
                 'discarded-snippet-title');
   }
 
+  function receiveContentSuggestions(categoriesList) {
+    displayList(categoriesList, 'content-suggestions',
+                'content-suggestion-title');
+  }
+
   function receiveJson(json) {
     var trimmed = json.trim();
     var hasContent = (trimmed && trimmed != '{}');
@@ -110,10 +127,10 @@ cr.define('chrome.SnippetsInternals', function() {
 
     var links = document.getElementsByClassName(titleClass);
     for (var link of links) {
-      link.addEventListener('click', function(event) {
-        var id = event.currentTarget.getAttribute('snippet-id');
+      link.onclick = function(event) {

[Marc Treib, 2016/07/12 13:04:52]

Forgive my ignorance, but is there any difference between onclick and
addEventListener('click' ?

[Bernhard Bauer, 2016/07/12 13:09:45]

I would either use addEventListener everywhere or onclick everywhere.

[Philipp Keck, 2016/07/12 13:45:02]

onclick allows for one, removal by ".onclick = null;" whereas addEventListener
can add multiple and remove them with removeEventListener. However, to remove
you still need the reference to the function you added previously and there is
no "remove all". Removing/Overwriting is important here because otherwise it is
executed twice after a reload (and three times after the next), causing the
thing to open and immediately close again. Don't know why that wasn't an issue
before?

The same problem doesn't occur with the addEventListeners in initialize() above,
but the idea there is also more of the "onclick" than the "addEventListener"
kind, so I could change it there, too.

However, the addEventListener below can't be changed because there is no
equivalent onxyz event, afaik.

To be consistent with existing code, I just make the old lambda a named
function, then addEventListener will avoid registering it twice automatically.

[Marc Treib, 2016/07/12 13:49:47]

I'm moderately sure that it *was* actually an issue before - "sometimes" the
hide/unhide toggle wouldn't work, I think nobody ever investigated why :D
SGTM

[jkrcal, 2016/07/13 11:35:23]

I can confirm that the toggle behaved weirdly sometimes. I did a bit of
investigation but have been dragged away by some more pushing issues :)

+        var id = event.currentTarget.getAttribute('hidden-id');
         $(id).classList.toggle('hidden');
-      });
+      };
     }
   }
 
@@ -125,6 +142,7 @@ cr.define('chrome.SnippetsInternals', function() {
     receiveHosts: receiveHosts,
     receiveSnippets: receiveSnippets,
     receiveDiscardedSnippets: receiveDiscardedSnippets,
+    receiveContentSuggestions: receiveContentSuggestions,
     receiveJson: receiveJson,
   };
 });