Add ContentSuggestionsService to SnippetsInternals

chrome/browser/resources/snippets_internals.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('chrome.SnippetsInternals', function() {
   'use strict';
 
   // Stores the list of snippets we received in receiveSnippets.
   var lastSnippets = [];
 
@@ skipping 20 matching lines @@
     $('last-json-dump').addEventListener('click', function(event) {
       downloadJson($('last-json-text').innerText);
       event.preventDefault();
     });
 
     $('discarded-snippets-clear').addEventListener('click', function(event) {
       chrome.send('clearDiscarded');
       event.preventDefault();
     });
 
+    $('submit-clear-cached-suggestions')
+        .addEventListener('click', function(event) {
+      chrome.send('clearCachedSuggestions');
+      event.preventDefault();
+    });
+
+    $('submit-clear-discarded-suggestions')
+        .addEventListener('click', function(event) {
+      chrome.send('clearDiscardedSuggestions');
+      event.preventDefault();
+    });
+
     chrome.send('loaded');
   }
 
   function setHostRestricted(restricted) {
     receiveProperty('switch-restrict-to-hosts', restricted ? 'True' : 'False');
     if (!restricted) {
       $('hosts-restrict').classList.add('hidden');
     }
   }
 
@@ skipping 11 matching lines @@
   function receiveSnippets(snippets) {
     lastSnippets = snippets;
     displayList(snippets, 'snippets', 'snippet-title');
   }
 
   function receiveDiscardedSnippets(discardedSnippets) {
     displayList(discardedSnippets, 'discarded-snippets',
                 'discarded-snippet-title');
   }
 
+  function receiveContentSuggestions(categoriesList) {
+    displayList(categoriesList, 'content-suggestions',
+                'content-suggestion-title');
+  }
+
   function receiveJson(json) {
     var trimmed = json.trim();
     var hasContent = (trimmed && trimmed != '{}');
 
     if (hasContent) {
       receiveProperty('last-json-text', trimmed);
       $('last-json').classList.remove('hidden');
     } else {
       $('last-json').classList.add('hidden');
     }
@@ skipping 21 matching lines @@
     } else {
       text = 'The list is empty.';
       display = 'none';
     }
 
     if ($(domId + '-empty')) $(domId + '-empty').textContent = text;
     if ($(domId + '-clear')) $(domId + '-clear').style.display = display;
 
     var links = document.getElementsByClassName(titleClass);
     for (var link of links) {
-      link.addEventListener('click', function(event) {
-        var id = event.currentTarget.getAttribute('snippet-id');
+      link.onclick = function(event) {

[Marc Treib, 2016/07/12 13:04:52]

Forgive my ignorance, but is there any difference between onclick and
addEventListener('click' ?

[Bernhard Bauer, 2016/07/12 13:09:45]

I would either use addEventListener everywhere or onclick everywhere.

[Philipp Keck, 2016/07/12 13:45:02]

onclick allows for one, removal by ".onclick = null;" whereas addEventListener
can add multiple and remove them with removeEventListener. However, to remove
you still need the reference to the function you added previously and there is
no "remove all". Removing/Overwriting is important here because otherwise it is
executed twice after a reload (and three times after the next), causing the
thing to open and immediately close again. Don't know why that wasn't an issue
before?

The same problem doesn't occur with the addEventListeners in initialize() above,
but the idea there is also more of the "onclick" than the "addEventListener"
kind, so I could change it there, too.

However, the addEventListener below can't be changed because there is no
equivalent onxyz event, afaik.

To be consistent with existing code, I just make the old lambda a named
function, then addEventListener will avoid registering it twice automatically.

[Marc Treib, 2016/07/12 13:49:47]

I'm moderately sure that it *was* actually an issue before - "sometimes" the
hide/unhide toggle wouldn't work, I think nobody ever investigated why :D
SGTM

[jkrcal, 2016/07/13 11:35:23]

I can confirm that the toggle behaved weirdly sometimes. I did a bit of
investigation but have been dragged away by some more pushing issues :)

+        var id = event.currentTarget.getAttribute('hidden-id');
         $(id).classList.toggle('hidden');
-      });
+      };
     }
   }
 
   // Return an object with all of the exports.
   return {
     initialize: initialize,
     setHostRestricted: setHostRestricted,
     receiveProperty: receiveProperty,
     receiveHosts: receiveHosts,
     receiveSnippets: receiveSnippets,
     receiveDiscardedSnippets: receiveDiscardedSnippets,
+    receiveContentSuggestions: receiveContentSuggestions,
     receiveJson: receiveJson,
   };
 });
 
 document.addEventListener('DOMContentLoaded',
                           chrome.SnippetsInternals.initialize);