Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2145553002: Parameterize OnError method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Parameterize OnError method. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index 386f630876a9c71a1349abdb661c91fee410b93f..1ddd6e7f257e022d6670e3b05c2f8bb244c34186 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -36,6 +36,7 @@ using blink::mojom::blink::PaymentDetails;
using blink::mojom::blink::PaymentDetailsModifier;
using blink::mojom::blink::PaymentDetailsModifierPtr;
using blink::mojom::blink::PaymentDetailsPtr;
+using blink::mojom::blink::PaymentErrorReason;
using blink::mojom::blink::PaymentItem;
using blink::mojom::blink::PaymentItemPtr;
using blink::mojom::blink::PaymentMethodData;
@@ -372,7 +373,7 @@ ScriptPromise PaymentRequest::show(ScriptState* scriptState)
DCHECK(!m_paymentProvider.is_bound());
scriptState->domWindow()->frame()->serviceRegistry()->connectToRemoteService(mojo::GetProxy(&m_paymentProvider));
- m_paymentProvider.set_connection_error_handler(convertToBaseCallback(WTF::bind(&PaymentRequest::OnError, wrapWeakPersistent(this))));
+ m_paymentProvider.set_connection_error_handler(convertToBaseCallback(WTF::bind(&PaymentRequest::OnError, wrapWeakPersistent(this), mojom::blink::PaymentErrorReason::UNKNOWN)));
m_paymentProvider->SetClient(m_clientBinding.CreateInterfacePtrAndBind());
m_paymentProvider->Show(mojo::WTFArray<mojom::blink::PaymentMethodDataPtr>::From(m_methodData), mojom::blink::PaymentDetails::From(m_details), mojom::blink::PaymentOptions::From(m_options));
@@ -586,14 +587,27 @@ void PaymentRequest::OnPaymentResponse(mojom::blink::PaymentResponsePtr response
m_showResolver.clear();
}
-void PaymentRequest::OnError()
+void PaymentRequest::OnError(mojo::PaymentErrorReason error)
{
+ ExceptionCode ec = SyntaxError;
+ String message = "The payment request is cancelled due to unknown reasons.";
please use gerrit instead 2016/07/12 15:57:35 Other error messages in this file do not have a pe
pals 2016/07/13 05:54:27 Done.
+ switch (error) {
+ case mojom::blink::PaymentErrorReason::USER_CANCEL:
+ message = "User cancelled the payment request.";
please use gerrit instead 2016/07/12 15:57:35 Remove the period.
pals 2016/07/13 05:54:27 Done.
+ break;
+ case mojom::blink::PaymentErrorReason::NOT_SUPPORTED:
+ ec = NotSupportedError;
+ message = "The payment method is not supported.";
please use gerrit instead 2016/07/12 15:57:35 Remove the period.
pals 2016/07/13 05:54:27 Done.
+ break;
+ default:
please use gerrit instead 2016/07/12 15:57:35 Instead of "default", put the "UNKNOWN" enum value
pals 2016/07/13 05:54:27 Done.
+ break;
+ }
if (m_completeResolver)
- m_completeResolver->reject(DOMException::create(SyntaxError, "Request cancelled"));
+ m_completeResolver->reject(DOMException::create(ec, message));
if (m_showResolver)
- m_showResolver->reject(DOMException::create(SyntaxError, "Request cancelled"));
+ m_showResolver->reject(DOMException::create(ec, message));
if (m_abortResolver)
- m_abortResolver->reject(DOMException::create(SyntaxError, "Request cancelled"));
+ m_abortResolver->reject(DOMException::create(ec, message));
clearResolversAndCloseMojoConnection();
}

Powered by Google App Engine
This is Rietveld 408576698