third_party/WebKit/public/platform/modules/payments/payment_request.mojom - Issue 2145553002: Parameterize OnError method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Issue 2145553002: Parameterize OnError method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

diff --git a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

index 6a113f58e5ae63da1b2465db1ed0ffd6fb6ca470..bd9421fc520d604d1e46761fca5124a0268a6440 100644

--- a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

+++ b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

@@ -63,11 +63,17 @@ struct PaymentResponse {

string? payer_phone;

};

+enum PaymentErrorReason {

+ UNKNOWN,

+ CANCEL,

+ NOT_SUPPORTED

+};

interface PaymentRequestClient {

OnShippingAddressChange(PaymentAddress address);

OnShippingOptionChange(string shipping_option_id);

OnPaymentResponse(PaymentResponse response);

- OnError();

+ OnError(PaymentErrorReason error);

OnComplete();

OnAbort(bool aborted_successfully);

};

« third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp ('k') | no next file » | no next file with comments »