chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2145553002: Parameterize OnError method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2145553002: Parameterize OnError method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 360ab4ad67ee38eef702f31cb2ffa1f82a82e97e..528c04014aa121542f07bf9b4489db764bfce579 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -31,6 +31,7 @@ import org.chromium.content_public.browser.WebContents;

import org.chromium.mojo.system.MojoException;

import org.chromium.mojom.payments.PaymentComplete;

import org.chromium.mojom.payments.PaymentDetails;

+import org.chromium.mojom.payments.PaymentErrorReason;

import org.chromium.mojom.payments.PaymentItem;

import org.chromium.mojom.payments.PaymentMethodData;

import org.chromium.mojom.payments.PaymentOptions;

@@ -830,7 +831,7 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

private void disconnectFromClientWithDebugMessage(String debugMessage) {

Log.d(TAG, debugMessage);

- mClient.onError();

+ mClient.onError(PaymentErrorReason.CANCEL);

please use gerrit instead 2016/07/14 22:44:46 Sorry, didn't mean to make you switch from USER_CA

closeClient();

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')