Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: gpu/tools/compositor_model_bench/render_models.cc

Issue 2145543002: Use base::FooValue::From() to simplify gpu code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/tools/compositor_model_bench/render_models.h ('k') | gpu/tools/compositor_model_bench/render_tree.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/tools/compositor_model_bench/render_models.cc
diff --git a/gpu/tools/compositor_model_bench/render_models.cc b/gpu/tools/compositor_model_bench/render_models.cc
index bbbfac6cda64845392370af38f3b940e0de91d81..a784706a3e91f26b668a2fefc5355c952d742e19 100644
--- a/gpu/tools/compositor_model_bench/render_models.cc
+++ b/gpu/tools/compositor_model_bench/render_models.cc
@@ -5,7 +5,9 @@
#include "gpu/tools/compositor_model_bench/render_models.h"
#include <string>
+#include <utility>
+#include "base/memory/ptr_util.h"
#include "gpu/tools/compositor_model_bench/forward_render_model.h"
const char* ModelToString(RenderModel m) {
@@ -17,25 +19,24 @@ const char* ModelToString(RenderModel m) {
}
}
-RenderModelSimulator::RenderModelSimulator(RenderNode* root) : root_(root) {
-}
+RenderModelSimulator::RenderModelSimulator(std::unique_ptr<RenderNode> root)
+ : root_(std::move(root)) {}
RenderModelSimulator::~RenderModelSimulator() {
}
-RenderModelSimulator* ConstructSimulationModel(RenderModel model,
- RenderNode* render_tree_root,
- int window_width,
- int window_height) {
+std::unique_ptr<RenderModelSimulator> ConstructSimulationModel(
+ RenderModel model,
+ std::unique_ptr<RenderNode> render_tree_root,
+ int window_width,
+ int window_height) {
switch (model) {
case ForwardRenderModel:
- return new ForwardRenderSimulator(render_tree_root,
- window_width,
- window_height);
+ return base::WrapUnique(new ForwardRenderSimulator(
+ std::move(render_tree_root), window_width, window_height));
default:
LOG(ERROR) << "Unrecognized render model. "
"If we know its name, then it's..." << ModelToString(model);
- return 0;
+ return nullptr;
}
}
-
« no previous file with comments | « gpu/tools/compositor_model_bench/render_models.h ('k') | gpu/tools/compositor_model_bench/render_tree.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698