Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2857)

Unified Diff: chrome/test/base/web_ui_browser_test.cc

Issue 2145493002: ChromeOS Web UI Tests: make WebUIBrowserTest error message more readable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/web_ui_browser_test.cc
diff --git a/chrome/test/base/web_ui_browser_test.cc b/chrome/test/base/web_ui_browser_test.cc
index 4a55e86fc2e041d9b37aca86663e4c6dc6f2a426..5dd111115f0265efbb10e82bce7cccf93195bc04 100644
--- a/chrome/test/base/web_ui_browser_test.cc
+++ b/chrome/test/base/web_ui_browser_test.cc
@@ -459,7 +459,12 @@ bool WebUIBrowserTest::RunJavascriptUsingHandler(
test_handler_->RunJavaScript(content);
if (error_messages_.Get().size() > 0) {
- LOG(ERROR) << "Encountered javascript console error(s)";
+ LOG(ERROR) << "CONDITION FAILURE: encountered javascript console error(s):";
+ for (const auto& msg : error_messages_.Get()) {
+ LOG(ERROR) << "JS ERROR: '" << msg << "'";
michaelpg 2016/07/29 22:38:29 Do you not normally see console errors when your t
+ }
+ LOG(ERROR) << "JS call assumed failed, because JS console error(s) found.";
+
result = false;
error_messages_.Get().clear();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698