Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2145493002: ChromeOS Web UI Tests: make WebUIBrowserTest error message more readable. (Closed)

Created:
4 years, 5 months ago by Alexander Alekseev
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Web UI Tests: make WebUIBrowserTest error message more readable. WebUIBrowserTests fail if any JS console errors are found. This CL makes error mesages more readable in this case. BUG=604119 TEST=none Committed: https://crrev.com/b39d5a274015d54e191dccf8c2eaba490f8a875f Cr-Commit-Position: refs/heads/master@{#405418}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/test/base/web_ui_browser_test.cc View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 21 (12 generated)
Alexander Alekseev
Please review.
4 years, 5 months ago (2016-07-12 04:06:03 UTC) #2
Paweł Hajdan Jr.
LGTM, thanks!
4 years, 5 months ago (2016-07-13 11:01:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145493002/1
4 years, 5 months ago (2016-07-14 01:35:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 02:48:19 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 02:48:21 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b39d5a274015d54e191dccf8c2eaba490f8a875f Cr-Commit-Position: refs/heads/master@{#405418}
4 years, 5 months ago (2016-07-14 02:50:29 UTC) #17
michaelpg
https://codereview.chromium.org/2145493002/diff/1/chrome/test/base/web_ui_browser_test.cc File chrome/test/base/web_ui_browser_test.cc (right): https://codereview.chromium.org/2145493002/diff/1/chrome/test/base/web_ui_browser_test.cc#newcode464 chrome/test/base/web_ui_browser_test.cc:464: LOG(ERROR) << "JS ERROR: '" << msg << "'"; ...
4 years, 4 months ago (2016-07-29 22:38:29 UTC) #19
Alexander Alekseev
On 2016/07/29 22:38:29, michaelpg wrote: > https://codereview.chromium.org/2145493002/diff/1/chrome/test/base/web_ui_browser_test.cc > File chrome/test/base/web_ui_browser_test.cc (right): > > https://codereview.chromium.org/2145493002/diff/1/chrome/test/base/web_ui_browser_test.cc#newcode464 > ...
4 years, 4 months ago (2016-07-29 22:46:45 UTC) #20
michaelpg
4 years, 4 months ago (2016-07-29 22:50:42 UTC) #21
Message was sent while issue was closed.
On 2016/07/29 22:46:45, Alexander Alekseev wrote:
> On 2016/07/29 22:38:29, michaelpg wrote:
> >
>
https://codereview.chromium.org/2145493002/diff/1/chrome/test/base/web_ui_bro...
> > File chrome/test/base/web_ui_browser_test.cc (right):
> > 
> >
>
https://codereview.chromium.org/2145493002/diff/1/chrome/test/base/web_ui_bro...
> > chrome/test/base/web_ui_browser_test.cc:464: LOG(ERROR) << "JS ERROR: '" <<
> msg
> > << "'";
> > Do you not normally see console errors when your tests fail? I'm seeing
> > duplicate errors now because they're logged first during the test, and then
> > again at the end here. That's annoying IMO -- is this WAI?
> 
> I usually expect the test failure message to include the exact problem.
> We have a lot of different warnings and JS messages during tests run, so I was
> very surprised that I couldn't understand from the test failure message what
> exactly was wrong. And I spent quite some time looking for the source of the
> message and finding out what the problem was.
> 
> So I believe this is better than it was. But if you can make failure message
to
> include the exact messages that lead to the problem, it could be great!

Can you give an example of a test that this improves?

Powered by Google App Engine
This is Rietveld 408576698