Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 return node.profileNode === this._profileView.profile.idleNode ? "" : We bInspector.UIString("%.2f\u2009%%", value); 342 return node.profileNode === this._profileView.profile.idleNode ? "" : We bInspector.UIString("%.2f\u2009%%", value);
343 }, 343 },
344 344
345 /** 345 /**
346 * @override 346 * @override
347 * @param {!WebInspector.ProfileDataGridNode} node 347 * @param {!WebInspector.ProfileDataGridNode} node
348 * @return {!Element} 348 * @return {!Element}
349 */ 349 */
350 linkifyNode: function(node) 350 linkifyNode: function(node)
351 { 351 {
352 var callFrame = node.profileNode.frame; 352 return this._profileView.linkifier().linkifyConsoleCallFrameForTimeline( this._profileView.target(), node.profileNode.frame, "profile-node-file");
353 return this._profileView.linkifier().linkifyConsoleCallFrame(this._profi leView.target(), callFrame, "profile-node-file");
354 } 353 }
355 } 354 }
356 355
357 /** 356 /**
358 * @constructor 357 * @constructor
359 * @extends {WebInspector.ProfileFlameChartDataProvider} 358 * @extends {WebInspector.ProfileFlameChartDataProvider}
360 * @param {!WebInspector.CPUProfileDataModel} cpuProfile 359 * @param {!WebInspector.CPUProfileDataModel} cpuProfile
361 * @param {?WebInspector.Target} target 360 * @param {?WebInspector.Target} target
362 */ 361 */
363 WebInspector.CPUFlameChartDataProvider = function(cpuProfile, target) 362 WebInspector.CPUFlameChartDataProvider = function(cpuProfile, target)
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 if (ms < 1000) 470 if (ms < 1000)
472 return WebInspector.UIString("%.1f\u2009ms", ms); 471 return WebInspector.UIString("%.1f\u2009ms", ms);
473 return Number.secondsToString(ms / 1000, true); 472 return Number.secondsToString(ms / 1000, true);
474 } 473 }
475 var name = WebInspector.beautifyFunctionName(node.functionName); 474 var name = WebInspector.beautifyFunctionName(node.functionName);
476 pushEntryInfoRow(WebInspector.UIString("Name"), name); 475 pushEntryInfoRow(WebInspector.UIString("Name"), name);
477 var selfTime = millisecondsToString(this._entrySelfTimes[entryIndex]); 476 var selfTime = millisecondsToString(this._entrySelfTimes[entryIndex]);
478 var totalTime = millisecondsToString(timelineData.entryTotalTimes[entryI ndex]); 477 var totalTime = millisecondsToString(timelineData.entryTotalTimes[entryI ndex]);
479 pushEntryInfoRow(WebInspector.UIString("Self time"), selfTime); 478 pushEntryInfoRow(WebInspector.UIString("Self time"), selfTime);
480 pushEntryInfoRow(WebInspector.UIString("Total time"), totalTime); 479 pushEntryInfoRow(WebInspector.UIString("Total time"), totalTime);
481 var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (node);
482 var linkifier = new WebInspector.Linkifier(); 480 var linkifier = new WebInspector.Linkifier();
483 var text = linkifier.linkifyConsoleCallFrame(this._target, callFrame).te xtContent; 481 var text = linkifier.linkifyConsoleCallFrameForTimeline(this._target, no de).textContent;
484 linkifier.dispose(); 482 linkifier.dispose();
485 pushEntryInfoRow(WebInspector.UIString("URL"), text); 483 pushEntryInfoRow(WebInspector.UIString("URL"), text);
486 pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.s econdsToString(node.selfTime / 1000, true)); 484 pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.s econdsToString(node.selfTime / 1000, true));
487 pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number. secondsToString(node.totalTime / 1000, true)); 485 pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number. secondsToString(node.totalTime / 1000, true));
488 if (node.deoptReason && node.deoptReason !== "no reason") 486 if (node.deoptReason && node.deoptReason !== "no reason")
489 pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptR eason); 487 pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptR eason);
490 488
491 return entryInfo; 489 return entryInfo;
492 }, 490 },
493 491
494 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype 492 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype
495 } 493 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698