[DevTools] make Runtime.CallFrame 0-based

third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 186 matching lines @@
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {!RuntimeAgent.CallFrame} callFrame
      * @param {string=} classes
      * @return {!Element}
      */
     linkifyConsoleCallFrame: function(target, callFrame, classes)
     {
-        return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, WebInspector.DebuggerModel.fromOneBased(callFrame.lineNumber), WebInspector.DebuggerModel.fromOneBased(callFrame.columnNumber), classes);
+        return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, callFrame.columnNumber, classes);
     },
 
     /**
+     * @param {?WebInspector.Target} target
+     * @param {!RuntimeAgent.CallFrame} callFrame
+     * @param {string=} classes
+     * @return {!Element}
+     */
+    linkifyConsoleCallFrameForTimeline: function(target, callFrame, classes)
+    {
+        // TODO(kozyatinskiy): remove this when Profilers will migrate to 0-based lineNumber and columnNumber.
+        return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes);
+    },
+
+    /**
      * @param {!WebInspector.Target} target
      * @param {!RuntimeAgent.StackTrace} stackTrace
      * @param {string=} classes
      * @return {!Element}
      */
     linkifyStackTraceTopFrame: function(target, stackTrace, classes)
     {
         console.assert(stackTrace.callFrames && stackTrace.callFrames.length);
 
         var topFrame = stackTrace.callFrames[0];
-        var fallbackAnchor = WebInspector.linkifyResourceAsNode(topFrame.url, WebInspector.DebuggerModel.fromOneBased(topFrame.lineNumber), WebInspector.DebuggerModel.fromOneBased(topFrame.columnNumber), classes);
+        var fallbackAnchor = WebInspector.linkifyResourceAsNode(topFrame.url, topFrame.lineNumber, topFrame.columnNumber, classes);
         if (target.isDetached())
             return fallbackAnchor;
 
         var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
         var rawLocations = debuggerModel.createRawLocationsByStackTrace(stackTrace);
         if (rawLocations.length === 0)
             return fallbackAnchor;
 
         var anchor = this._createAnchor(classes);
         var liveLocation = WebInspector.debuggerWorkspaceBinding.createStackTraceTopFrameLiveLocation(rawLocations, this._updateAnchor.bind(this, anchor), /** @type {!WebInspector.LiveLocationPool} */(this._locationPoolByTarget.get(target)));
@@ skipping 354 matching lines @@
 /**
  * @param {!WebInspector.NetworkRequest} request
  * @return {!Element}
  */
 WebInspector.linkifyRequestAsNode = function(request)
 {
     var anchor = WebInspector.linkifyURLAsNode(request.url);
     anchor.requestId = request.requestId;
     return anchor;
 }