[DevTools] make Runtime.CallFrame 0-based

third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 70 matching lines @@
      * @param {!WebInspector.ConsoleMessage} message
      * @return {?WebInspector.DebuggerModel.Location}
      */
     _rawLocation: function(message)
     {
         var debuggerModel = WebInspector.DebuggerModel.fromTarget(message.target());
         if (!debuggerModel)
             return null;
         var callFrame = message.stackTrace && message.stackTrace.callFrames ? message.stackTrace.callFrames[0] : null;
         // FIXME(62725): stack trace line/column numbers are one-based.
-        var lineNumber = callFrame ? callFrame.lineNumber - 1 : message.line - 1;
+        var lineNumber = callFrame ? callFrame.lineNumber : message.line - 1;
         var columnNumber = message.column ? message.column - 1 : 0;
-        if (callFrame && callFrame.columnNumber)
-            columnNumber = callFrame.columnNumber - 1;
+        if (callFrame && callFrame.hasOwnProperty("columnNumber"))

[dgozman, 2016/07/12 18:34:00]

It's not optional.

[kozy, 2016/07/12 19:14:57]

Done.

+            columnNumber = callFrame.columnNumber;
         if (message.scriptId)
             return debuggerModel.createRawLocationByScriptId(message.scriptId, lineNumber, columnNumber);
         return debuggerModel.createRawLocationByURL(message.url || "", lineNumber, columnNumber);
     },
 
     /**
      * @param {!WebInspector.ConsoleMessage} message
      * @param {!WebInspector.DebuggerModel.Location} rawLocation
      */
     _addConsoleMessageToScript: function(message, rawLocation)
@@ skipping 86 matching lines @@
 
     dispose: function()
     {
         if (this._uiMessage)
             this._uiMessage.remove();
     }
 }
 
 /** @type {!WebInspector.PresentationConsoleMessageHelper} */
 WebInspector.presentationConsoleMessageHelper;