src/objects.cc - Issue 214543003: Fix JSObject::SetElement for fixed typed array elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 214543003: Fix JSObject::SetElement for fixed typed array elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 0013e720d48ea0f0389dc528feed442af8128bc3..a6d0403ab5d6dbaf86eb1d6ace19eab13928676a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -12410,7 +12410,8 @@ Handle<Object> JSObject::SetElement(Handle<JSObject> object,

SetPropertyMode set_mode) {

Isolate* isolate = object->GetIsolate();

- if (object->HasExternalArrayElements()) {

+ if (object->HasExternalArrayElements() ||

+ object->HasFixedTypedArrayElements()) {

if (!value->IsNumber() && !value->IsUndefined()) {

bool has_exception;

Handle<Object> number =

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-357108.js » ('j') | no next file with comments »