|
|
Created:
6 years, 9 months ago by bulach Modified:
6 years, 9 months ago CC:
chromium-reviews, erikwright+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAndroid: improves error message for Outer.Inner usage in JNI.
The JNI generator was wrongly identifying Outer.Inner.
Raise an exception with a clearer message.
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260103
Patch Set 1 #
Messages
Total messages: 23 (0 generated)
I haven't invented a time machine yet, but this would have solved the issue you found yesterday :) hopefully it'll help someone in the future..
LGTM Great, thanks!
The CQ bit was checked by bulach@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
+peter for RS
lgtm
The CQ bit was checked by bulach@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by bulach@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by bulach@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by bulach@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
Message was sent while issue was closed.
Change committed as 260103 |