Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 214543002: Android: improves error message for Outer.Inner usage in JNI. (Closed)

Created:
6 years, 9 months ago by bulach
Modified:
6 years, 9 months ago
Reviewers:
Peter Beverloo, mcasas
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: improves error message for Outer.Inner usage in JNI. The JNI generator was wrongly identifying Outer.Inner. Raise an exception with a clearer message. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M base/android/jni_generator/jni_generator.py View 2 chunks +7 lines, -0 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
bulach
I haven't invented a time machine yet, but this would have solved the issue you ...
6 years, 9 months ago (2014-03-27 09:59:18 UTC) #1
mcasas
LGTM Great, thanks!
6 years, 9 months ago (2014-03-27 10:36:40 UTC) #2
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 9 months ago (2014-03-27 14:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
6 years, 9 months ago (2014-03-27 14:56:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:56:44 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-27 14:56:44 UTC) #6
bulach
+peter for RS
6 years, 9 months ago (2014-03-27 15:35:11 UTC) #7
Peter Beverloo
lgtm
6 years, 9 months ago (2014-03-27 15:50:46 UTC) #8
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 9 months ago (2014-03-27 15:51:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
6 years, 9 months ago (2014-03-27 15:53:15 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:19:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-27 16:19:50 UTC) #12
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 9 months ago (2014-03-27 16:44:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
6 years, 9 months ago (2014-03-27 16:45:58 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:59:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-27 16:59:46 UTC) #16
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 9 months ago (2014-03-27 19:04:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
6 years, 9 months ago (2014-03-27 19:10:48 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:57:27 UTC) #19
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 21:57:28 UTC) #20
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 9 months ago (2014-03-28 08:21:14 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/214543002/1
6 years, 9 months ago (2014-03-28 08:22:56 UTC) #22
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 11:15:07 UTC) #23
Message was sent while issue was closed.
Change committed as 260103

Powered by Google App Engine
This is Rietveld 408576698