Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2145413002: [builtins] unify builtins list. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] unify builtins list. Now builtins are sorted by use, not implementation. R=bmeurer@chromium.org BUG=v8:5197 Committed: https://crrev.com/5abc73a1e8ec1b96fcc01dc045dc3dbfa4d36515 Cr-Commit-Position: refs/heads/master@{#37761}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -497 lines) Patch
M src/builtins/builtins.h View 1 2 3 chunks +382 lines, -399 lines 0 comments Download
M src/builtins/builtins.cc View 1 4 chunks +62 lines, -84 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/external-reference-table.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Yang
4 years, 5 months ago (2016-07-14 11:25:18 UTC) #1
Benedikt Meurer
LGTM.
4 years, 5 months ago (2016-07-14 11:38:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145413002/40001
4 years, 5 months ago (2016-07-14 12:43:51 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 12:46:01 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 12:46:22 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5abc73a1e8ec1b96fcc01dc045dc3dbfa4d36515
Cr-Commit-Position: refs/heads/master@{#37761}

Powered by Google App Engine
This is Rietveld 408576698