Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2145403002: Revert of Re-reland: Add MemoryCoordinator (Closed)

Created:
4 years, 5 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 5 months ago
Reviewers:
haraken, chrisha, jam, dcheng, bashi
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-reland: Add MemoryCoordinator (patchset #2 id:20001 of https://codereview.chromium.org/2149063002/ ) Reason for revert: Seems to break building on Windows. See https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/45228/steps/compile/logs/stdio [11860/34084] CXX obj\components\memory_coordinator\child\memory_coordinator_child.child_memory_coordinator_impl.obj FAILED: obj/components/memory_coordinator/child/memory_coordinator_child.child_memory_coordinator_impl.obj ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\components\memory_coordinator\child\memory_coordinator_child.child_memory_coordinator_impl.obj.rsp /c ..\..\components\memory_coordinator\child\child_memory_coordinator_impl.cc /Foobj\components\memory_coordinator\child\memory_coordinator_child.child_memory_coordinator_impl.obj /Fdobj\components\memory_coordinator_child.cc.pdb c:\b\build\slave\win\build\src\services\shell\public\cpp\interface_provider.h(8): fatal error C1083: Cannot open include file: 'services/shell/public/interfaces/interface_provider.mojom.h': No such file or directory [11861/34084] CXX obj\mojo\gen\mojo\public\interfaces\bindings\tests\mojo_public_test_interfaces_blink.no_module.mojom-blink.obj Original issue's description: > Re-reland: Add MemoryCoordinator > > This is second attempt. Hope GYP Mac is happy with this :( > > Original description: > > This CL adds MemoryCoordinator mojo interface and > its implementation. When --enable-features=MemoryCoordinator > is specified the browser and renderers create their > MemoryCoordinators. MemoryCoordinatorImpl (which lives in > the browser process) creates a mojo message pipe when a > renderer is launched. > > This CL doesn't add actual handling of memory events, which > will be implemented in follow-up CLs. > > BUG=617492 > TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromium.org > > Committed: https://crrev.com/94d4a4349b199ffef3ee1c4a8616b05b225f7dc9 > Cr-Commit-Position: refs/heads/master@{#405460} TBR=chrisha@chromium.org,dcheng@chromium.org,haraken@chromium.org,jam@chromium.org,bashi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617492 Committed: https://crrev.com/0e9b2dc4e1e523ef831b482fffece884c2ec1464 Cr-Commit-Position: refs/heads/master@{#405468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -351 lines) Patch
M components/memory_coordinator.gypi View 2 chunks +1 line, -19 lines 0 comments Download
M components/memory_coordinator/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/memory_coordinator/browser/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/memory_coordinator/browser/memory_coordinator.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M components/memory_coordinator/child/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.h View 2 chunks +6 lines, -14 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 chunk +5 lines, -19 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc View 5 chunks +17 lines, -15 lines 0 comments Download
M components/memory_coordinator/common/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_features.h View 1 chunk +0 lines, -24 lines 0 comments Download
D components/memory_coordinator/common/memory_coordinator_features.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M components/memory_coordinator/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/memory_coordinator/public/interfaces/memory_coordinator.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
henrika (OOO until Aug 14)
Created Revert of Re-reland: Add MemoryCoordinator
4 years, 5 months ago (2016-07-14 11:19:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145403002/1
4 years, 5 months ago (2016-07-14 11:19:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 11:20:42 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 11:20:50 UTC) #6
bashi
lgtm. Thanks for reverting.
4 years, 5 months ago (2016-07-14 11:21:34 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e9b2dc4e1e523ef831b482fffece884c2ec1464 Cr-Commit-Position: refs/heads/master@{#405468}
4 years, 5 months ago (2016-07-14 11:22:33 UTC) #9
haraken
4 years, 5 months ago (2016-07-14 12:47:38 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698