Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2145393004:
[FRE] Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE (Closed)
|
Created:
4 years, 5 months ago by gogerald1 Modified:
4 years, 5 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE
The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes.
BUG=626993
Committed: https://crrev.com/79883706b57beb4ecaa50a70732e42b8df155b91
Cr-Commit-Position: refs/heads/master@{#405999}
Patch Set 1 : comments #
Messages
Total messages: 26 (20 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== fix bug BUG= ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to start lightweight FRE Flag USE_FRE_FLOW_SEQUENCER not only used to generate full FRE sequence but also used to avoid regenerate the sequence when full FRE restart in the middle. BUG=626993 ==========
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to start lightweight FRE Flag USE_FRE_FLOW_SEQUENCER not only used to generate full FRE sequence but also used to avoid regenerate the sequence when full FRE restart in the middle. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to start lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerate the sequence when full FRE restart in the middle. BUG=626993 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to start lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerate the sequence when full FRE restart in the middle. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to start lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. BUG=626993 ==========
gogerald@chromium.org changed reviewers: + bauerb@chromium.org
Hi, PTAL,
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to start lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. It was removed after generating the full FRE sequence. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. It was removed after generating the full FRE sequence. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. It was removed after generating the full FRE sequence. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. It was removed after generating the full FRE sequence. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. The flag was removed after generating the full FRE sequence. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE Flag USE_FRE_FLOW_SEQUENCER is not only used to generate full FRE sequence but also used to avoid regenerating of the sequence when full FRE restart in the middle. The flag was removed after generating the full FRE sequence. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence again when the full FRE restarts in the middle. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence again when the full FRE restarts in the middle. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts in the middle. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts in the middle. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence during restart. BUG=626993 ==========
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence during restart. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes. BUG=626993 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes. BUG=626993 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes. BUG=626993 ========== to ========== Do no reuse flag USE_FRE_FLOW_SEQUENCER to infer lightweight FRE The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes. BUG=626993 Committed: https://crrev.com/79883706b57beb4ecaa50a70732e42b8df155b91 Cr-Commit-Position: refs/heads/master@{#405999} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/79883706b57beb4ecaa50a70732e42b8df155b91 Cr-Commit-Position: refs/heads/master@{#405999} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
