Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2145363002: Enable occlusion query feature on OpenGL3.3 and later (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve related unittest errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 28ec470cad4f82d3de27ea84a216aafee4d3f267..36ff5e10a3189660680848ee6bcccc4de3bed345 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -1235,6 +1235,30 @@ TEST_P(FeatureInfoTest, InitializeGLES3_occlusion_query_boolean) {
HasSubstr("GL_EXT_occlusion_query_boolean"));
}
EXPECT_TRUE(info_->feature_flags().occlusion_query_boolean);
+ EXPECT_TRUE(info_->feature_flags(
+ ).no_covert_any_samples_passed_conservative_target_for_es3);
+}
+
+TEST_P(FeatureInfoTest, InitializeGL33_occlusion_query_boolean) {
+ SetupInitExpectationsWithGLVersion("", "", "3.3");
+ if (GetContextType() == CONTEXT_TYPE_OPENGLES2) {
+ EXPECT_THAT(info_->extensions(),
+ HasSubstr("GL_EXT_occlusion_query_boolean"));
+ }
+ EXPECT_TRUE(info_->feature_flags().occlusion_query_boolean);
+ EXPECT_TRUE(info_->feature_flags(
+ ).covert_any_samples_passed_conservative_target_for_low_gl);
+}
+
+TEST_P(FeatureInfoTest, InitializeGL43_occlusion_query_boolean) {
+ SetupInitExpectationsWithGLVersion("", "", "4.3");
+ if (GetContextType() == CONTEXT_TYPE_OPENGLES2) {
+ EXPECT_THAT(info_->extensions(),
+ HasSubstr("GL_EXT_occlusion_query_boolean"));
+ }
+ EXPECT_TRUE(info_->feature_flags().occlusion_query_boolean);
+ EXPECT_FALSE(info_->feature_flags(
+ ).covert_any_samples_passed_conservative_target_for_low_gl);
}
TEST_P(FeatureInfoTest, InitializeOES_vertex_array_object) {

Powered by Google App Engine
This is Rietveld 408576698