Enable occlusion query feature on OpenGL3.3 and later

Enable occlusion query feature on OpenGL3.3 and later

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8dcb9ceda8266da45c4e98b08fd5f744dc89523b
Cr-Commit-Position: refs/heads/master@{#405964}

[xinghua.cao, 2016-07-14 08:16:20]

Description was changed from

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=
==========

to

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[xinghua.cao, 2016-07-14 08:45:48]

Description was changed from

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[xinghua.cao, 2016-07-14 08:46:00]

The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 08:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xinghua.cao, 2016-07-14 09:36:32]

xinghua.cao@intel.com changed reviewers:
+ qiankun.miao@intel.com, yunchao.he@intel.com

[xinghua.cao, 2016-07-14 09:37:13]

Please help to review it, thank you.

[commit-bot: I haz the power, 2016-07-14 10:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 10:45:51]

Dry run: This issue passed the CQ dry run.

[qiankun, 2016-07-14 12:41:17]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[qiankun, 2016-07-14 12:41:18]

Looks good to me. 
Please review: zmo@ kbr@

[Zhenyao Mo, 2016-07-14 18:09:02]

https://codereview.chromium.org/2145363002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2145363002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1072:
feature_flags_.no_covert_any_samples_passed_conservative_target_for_es3 =
I don't think you need two new flags for this purpose.  You only need to specify
three behaviors

1) core bahavior, either ES3+, or GL4.3+, or have ext_occlusion_query_boolean.

2) arb_occlusion_query2 behavior, not 1, and have arb_occlusion_query2

3) arb_occulision_query bahavior, not 1, and no arb_occlusion_query2, and have
arb_occlusion_query

And you only need two flags (no flag means no mapping, the core behavior).

Hope I explained myself clearly.

[xinghua.cao, 2016-07-15 04:57:24]

The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 04:57:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 04:57:42]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 05:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 05:06:55]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[xinghua.cao, 2016-07-15 06:00:29]

The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 06:00:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 06:00:36]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 06:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 06:10:13]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[qiankun, 2016-07-15 07:44:05]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 07:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 07:44:27]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 07:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 07:52:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[xinghua.cao, 2016-07-15 10:14:36]

The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 10:14:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 10:14:50]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 10:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 10:24:47]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xinghua.cao, 2016-07-16 13:01:51]

The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 13:01:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 13:02:00]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-16 13:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 13:08:08]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[xinghua.cao, 2016-07-18 02:16:04]

The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 02:16:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 02:16:11]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-18 03:11:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 03:11:33]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-07-18 03:16:18]

LGTM. I have discussed with Xinghua carefully offline, I think it is OK. Could
you have another look? @zmo and @kbr.

[Zhenyao Mo, 2016-07-18 04:20:48]

On 2016/07/18 03:16:18, yunchao wrote:
> LGTM. I have discussed with Xinghua carefully offline, I think it is OK. Could
> you have another look? @zmo and @kbr.

lgtm

[xinghua.cao, 2016-07-18 05:13:09]

The CQ bit was checked by xinghua.cao@intel.com

[commit-bot: I haz the power, 2016-07-18 05:13:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 05:13:21]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-18 08:07:13]

Description was changed from

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-18 08:07:14]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-18 08:07:17]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 08:10:48]

Description was changed from

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable occlusion query feature on OpenGL3.3 and later

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8dcb9ceda8266da45c4e98b08fd5f744dc89523b
Cr-Commit-Position: refs/heads/master@{#405964}
==========

[commit-bot: I haz the power, 2016-07-18 08:10:49]

Patchset 5 (id:??) landed as
https://crrev.com/8dcb9ceda8266da45c4e98b08fd5f744dc89523b
Cr-Commit-Position: refs/heads/master@{#405964}