third_party/WebKit/Source/core/dom/Node.cpp - Issue 2145323002: Content in disabled input field should not be selectable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2145323002: Content in disabled input field should not be selectable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated code for WebViewTest.LongPressImageTextArea test failure Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/input-readonly-select-expected.txt ('k') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 67d63800116666258395b42aebaecc96ab17e67a..4b59a28cc384d3a8538f44d83d77f3f6c46bbef7 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -961,6 +961,9 @@ int Node::maxCharacterOffset() const

// is obviously misplaced.

bool Node::canStartSelection() const

{

+ if (isDisabledFormControl(this))

+ return false;

if (hasEditableStyle())

return true;