Fix temporary zones: DoExpression should go into local_zone_.

Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=

Committed: https://crrev.com/d4341d1fea2373cd18fb7e31f0d97ababa00aa27
Cr-Commit-Position: refs/heads/master@{#37787}

[marja, 2016-07-14 10:30:17]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 10:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 10:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 10:54:12]

Dry run: This issue passed the CQ dry run.

[marja, 2016-07-14 12:20:36]

Description was changed from

==========
Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=
==========

to

==========
Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=
==========

[marja, 2016-07-14 12:23:50]

Adding a bunch of people who might have insights here (titzer, rossberg, adamk,
caitpotter88), could some of you review?

Re: discussion in https://codereview.chromium.org/1399893002/

If DoExpression indeed needs to be in local_zone_, we should probably have a
test which fails w/ this CL :) I think it doesn't need to be.

I'm planning to separate things into separate Zones even further, and for this I
need stuff to be in the correct Zones as much as possible, hence this CL. (I.e.,
I don't want stuff in the parser_zone_ unless it really has to be there.)

[titzer, 2016-07-14 12:27:12]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2016-07-14 12:27:12]

lgtm

As discussed in person, it should be safe to allocate the AST nodes in the
local_zone, since all the other AST nodes are allocated there and discarded at
the same time.

[rossberg, 2016-07-14 13:17:35]

LGTM too. I don't know why it is that way.

[marja, 2016-07-15 07:29:35]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-07-15 07:29:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 07:32:14]

Description was changed from

==========
Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=
==========

to

==========
Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=
==========

[commit-bot: I haz the power, 2016-07-15 07:32:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 07:32:33]

Description was changed from

==========
Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=
==========

to

==========
Fix temporary zones: DoExpression should go into local_zone_.

There's no use putting it into parser_zone_, and if we do so, it might
refer to dead memory (the Block is in local_zone_ which might get
discarded).

BUG=

Committed: https://crrev.com/d4341d1fea2373cd18fb7e31f0d97ababa00aa27
Cr-Commit-Position: refs/heads/master@{#37787}
==========

[commit-bot: I haz the power, 2016-07-15 07:32:34]

Patchset 1 (id:??) landed as
https://crrev.com/d4341d1fea2373cd18fb7e31f0d97ababa00aa27
Cr-Commit-Position: refs/heads/master@{#37787}