Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2145293002: base: Cherry pick "symbolize: Calculate a module's zero VA using program headers." from glog. (Closed)

Created:
4 years, 5 months ago by pcc1
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Cherry pick "symbolize: Calculate a module's zero VA using program headers." from glog. This is a cherry pick of upstream change https://github.com/google/glog/pull/115 to fix a symbolization issue when using lld. BUG=607968 R=thakis@chromium.org Committed: https://crrev.com/bc420d1f42f479494403990a252de5ce3e71e3ec Cr-Commit-Position: refs/heads/master@{#405427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M base/third_party/symbolize/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M base/third_party/symbolize/symbolize.cc View 3 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pcc1
4 years, 5 months ago (2016-07-14 02:18:05 UTC) #1
Nico
lgtm
4 years, 5 months ago (2016-07-14 02:25:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145293002/1
4 years, 5 months ago (2016-07-14 02:26:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 03:35:06 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 03:35:11 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 03:40:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc420d1f42f479494403990a252de5ce3e71e3ec
Cr-Commit-Position: refs/heads/master@{#405427}

Powered by Google App Engine
This is Rietveld 408576698