fix propagated type of lambdas in strong mode

fix propagated type of lambdas in strong mode

Lambda expressions were getting propagated type inference, which conflicts with the type that strong mode infers, resulting in incorrect hints.

This hasn't shown up in a user-visible way, even though the value stored in the AST was not correct. But once implicit casts are disabled in StrongTypeSystem it started showing up as a (misleading) hint message.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/e200e73893ab5852d5361bd7ebefd4867654665a

[Jennifer Messerly, 2016-07-14 00:39:39]

Description was changed from

==========
fix propagated type of lambdas in strong mode

BUG=
==========

to

==========
fix propagated type of lambdas in strong mode
==========

[Jennifer Messerly, 2016-07-14 00:39:39]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2016-07-14 00:43:52]

Description was changed from

==========
fix propagated type of lambdas in strong mode
==========

to

==========
fix propagated type of lambdas in strong mode

Lambda expressions were propagated type inference, which conflicts with the type
that strong mode infers, resulting in incorrect hints.

This hasn't shown up in a user-visible way, even though the value stored in the
AST was not correct. But once implicit casts are disabled in StrongTypeSystem it
started showing up as a (misleading) hint message.
==========

[Jennifer Messerly, 2016-07-14 00:44:02]

More context for this is here:
https://github.com/dart-lang/sdk/issues/26583#issuecomment-232505809

[Jennifer Messerly, 2016-07-14 00:44:21]

Description was changed from

==========
fix propagated type of lambdas in strong mode

Lambda expressions were propagated type inference, which conflicts with the type
that strong mode infers, resulting in incorrect hints.

This hasn't shown up in a user-visible way, even though the value stored in the
AST was not correct. But once implicit casts are disabled in StrongTypeSystem it
started showing up as a (misleading) hint message.
==========

to

==========
fix propagated type of lambdas in strong mode

Lambda expressions were getting propagated type inference, which conflicts with
the type that strong mode infers, resulting in incorrect hints.

This hasn't shown up in a user-visible way, even though the value stored in the
AST was not correct. But once implicit casts are disabled in StrongTypeSystem it
started showing up as a (misleading) hint message.
==========

[Brian Wilkerson, 2016-07-14 17:35:31]

lgtm

[Jennifer Messerly, 2016-07-14 20:52:49]

Description was changed from

==========
fix propagated type of lambdas in strong mode

Lambda expressions were getting propagated type inference, which conflicts with
the type that strong mode infers, resulting in incorrect hints.

This hasn't shown up in a user-visible way, even though the value stored in the
AST was not correct. But once implicit casts are disabled in StrongTypeSystem it
started showing up as a (misleading) hint message.
==========

to

==========
fix propagated type of lambdas in strong mode

Lambda expressions were getting propagated type inference, which conflicts with
the type that strong mode infers, resulting in incorrect hints.

This hasn't shown up in a user-visible way, even though the value stored in the
AST was not correct. But once implicit casts are disabled in StrongTypeSystem it
started showing up as a (misleading) hint message.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e200e73893ab5852d5361bd7ebefd4867654665a
==========

[Jennifer Messerly, 2016-07-14 20:52:50]

Committed patchset #1 (id:1) manually as
e200e73893ab5852d5361bd7ebefd4867654665a (presubmit successful).