Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2145263002: Rewrite test in terms of promise rejection (Closed)

Created:
4 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite test in terms of promise rejection This patch rewrites animation-finish-event-cancelled.html to listen for rejection of the animation's finished promise instead of using a combination of onfinish and assertions about code being unreached. This makes the test easier to read and brings it more in line with the style of tests in the web-platform-tests suite. BUG=623437 Committed: https://crrev.com/d8a910760e0c33dc93b4751e330b729936a1df5c Cr-Commit-Position: refs/heads/master@{#405384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html View 1 chunk +12 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
suzyh_UTC10 (ex-contributor)
4 years, 5 months ago (2016-07-14 00:04:17 UTC) #3
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-14 00:52:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145263002/1
4 years, 5 months ago (2016-07-14 00:52:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 01:22:38 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 01:22:47 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 01:25:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8a910760e0c33dc93b4751e330b729936a1df5c
Cr-Commit-Position: refs/heads/master@{#405384}

Powered by Google App Engine
This is Rietveld 408576698