Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2145243002: Revert of [android] Correct the URL scheme colors in the Omnibox. (Closed)

Created:
4 years, 5 months ago by qinmin
Modified:
4 years, 5 months ago
Reviewers:
Ted C, nyquist, palmer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [android] Correct the URL scheme colors in the Omnibox. (patchset #6 id:100001 of https://codereview.chromium.org/2144443002/ ) Reason for revert: This change breaks Android Tests(dbg) bot, see logs here: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35273 Original issue's description: > [android] Correct the URL scheme colors in the Omnibox. > > Make the empahsized "https:" scheme text match the connection state indicator > icon color. (In the new design, the color changed.) Also, per the new design, > don't emphasize (color) the scheme for Incognito or theme colors. > > BUG=626646 > TBR=tedchoc > > Committed: https://crrev.com/cfd0445d8d4756d778e1b324dc739a7c1e51b128 > Cr-Commit-Position: refs/heads/master@{#405258} TBR=tedchoc@chromium.org,nyquist@chromium.org,palmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java View 2 chunks +15 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
qinmin
Created Revert of [android] Correct the URL scheme colors in the Omnibox.
4 years, 5 months ago (2016-07-13 23:09:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145243002/1
4 years, 5 months ago (2016-07-13 23:10:23 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:12:23 UTC) #5
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698