Source/core/editing/TextIterator.cpp - Issue 214523008: Use RenderStyle::isCollapsibleWhiteSpace when renderer is available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextIterator.cpp

Issue 214523008: Use RenderStyle::isCollapsibleWhiteSpace when renderer is available. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address reviewer comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/TextIterator.cpp

diff --git a/Source/core/editing/TextIterator.cpp b/Source/core/editing/TextIterator.cpp

index 964fee013391ee93af760b1c02e5355e041a1314..7db31b7f24e72724a41e984a6872f3e5007ffae5 100644

--- a/Source/core/editing/TextIterator.cpp

+++ b/Source/core/editing/TextIterator.cpp

@@ -668,7 +668,7 @@ void TextIterator::handleTextBox()

InlineTextBox* firstTextBox = renderer->containsReversedText() ? (m_sortedTextBoxes.isEmpty() ? 0 : m_sortedTextBoxes[0]) : renderer->firstTextBox();

bool needSpace = m_lastTextNodeEndedWithCollapsedSpace

|| (m_textBox == firstTextBox && textBoxStart == runStart && runStart > 0);

- if (needSpace && !isCollapsibleWhitespace(m_lastCharacter) && m_lastCharacter) {

+ if (needSpace && !renderer->style()->isCollapsibleWhiteSpace(m_lastCharacter) && m_lastCharacter) {

if (m_lastTextNode == m_node && runStart > 0 && str[runStart - 1] == ' ') {

unsigned spaceRunStart = runStart - 1;

while (spaceRunStart > 0 && str[spaceRunStart - 1] == ' ')

« no previous file with comments | « Source/core/editing/TextIterator.h ('k') | Source/core/editing/htmlediting.h » ('j') | no next file with comments »