Issue 214523007: Revert of Avoid unnecessary descents into nested boxes with floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214523007: Revert of Avoid unnecessary descents into nested boxes with floats. (Closed)

Created:
6 years, 9 months ago by rhogan

Modified:
6 years, 9 months ago

Reviewers:
leviw_travelin_and_unemployed, Bem Jones-Bey (adobe), ojan, Julien - ping for review

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Revert of Avoid unnecessary descents into nested boxes with floats. (https://codereview.chromium.org/195363007/) Reason for revert: Caused a lot of float crashes in ClusterFuzz https://code.google.com/p/chromium/issues/detail?id=357242 Original issue's description: > Avoid unnecessary descents into nested boxes with floats. > > Steal a bit from RenderBlock to avoid descending through the same > stack of nested boxes multiple times while preparing to lay them out. > > > This CL creates a 4% improvement in the > Performance/Layout/floats_*_nested.html tests. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170060 TBR=ojan@chromium.org,leviw@chromium.org,bjonesbe@adobe.com,jchaffraix@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170194

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	Source/core/rendering/RenderBlock.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

rhogan

Created Revert of Avoid unnecessary descents into nested boxes with floats.

6 years, 9 months ago (2014-03-27 18:41:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/214523007/1

6 years, 9 months ago (2014-03-27 18:41:14 UTC) #2

Message was sent while issue was closed.

Change committed as 170194