Subzero: implemented wrapper script to replace calls to calloc()

implemented wrapper script to replace calls to calloc()

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f0f80654e8bafb18d795c3c77f590ee885ea753a

[tlively, 2016-07-13 22:04:57]

tlively@google.com changed reviewers:
+ kschimpf@google.com, mcgrathr@chromium.org, stichnot@chromium.org

[Karl, 2016-07-14 17:33:51]

https://codereview.chromium.org/2145213002/diff/20001/docs/ASAN.rst
File docs/ASAN.rst (right):

https://codereview.chromium.org/2145213002/diff/20001/docs/ASAN.rst#newcode18
docs/ASAN.rst:18: Furthermore, pnacl-clang automatically inlines calls to
calloc(), even with
s/calls/some calls/?

Do you know it does this to all calls?

https://codereview.chromium.org/2145213002/diff/20001/pydir/sz-clang.py
File pydir/sz-clang.py (right):

https://codereview.chromium.org/2145213002/diff/20001/pydir/sz-clang.py#newco...
pydir/sz-clang.py:67: args[i] = dest_name
Ok. I now understand the following code. I suggest adding a comment to clarify
that you are adding a "dummy" implementation of the substituted calloc, when not
doing (single file) compilation.

[tlively, 2016-07-14 20:26:14]

https://codereview.chromium.org/2145213002/diff/20001/docs/ASAN.rst
File docs/ASAN.rst (right):

https://codereview.chromium.org/2145213002/diff/20001/docs/ASAN.rst#newcode18
docs/ASAN.rst:18: Furthermore, pnacl-clang automatically inlines calls to
calloc(), even with
On 2016/07/14 17:33:50, Karl wrote:
> s/calls/some calls/?
> 
> Do you know it does this to all calls?

Done.

https://codereview.chromium.org/2145213002/diff/20001/pydir/sz-clang.py
File pydir/sz-clang.py (right):

https://codereview.chromium.org/2145213002/diff/20001/pydir/sz-clang.py#newco...
pydir/sz-clang.py:67: args[i] = dest_name
On 2016/07/14 17:33:50, Karl wrote:
> Ok. I now understand the following code. I suggest adding a comment to clarify
> that you are adding a "dummy" implementation of the substituted calloc, when
not
> doing (single file) compilation.

Done.

[tlively, 2016-07-14 20:31:14]

Description was changed from

==========
implemented wrapper script to replace calls to calloc()

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

to

==========
implemented wrapper script to replace calls to calloc()

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

[Karl, 2016-07-14 20:36:29]

lgtm

https://codereview.chromium.org/2145213002/diff/40001/docs/ASAN.rst
File docs/ASAN.rst (right):

https://codereview.chromium.org/2145213002/diff/40001/docs/ASAN.rst#newcode27
docs/ASAN.rst:27: sz-clang.py -fno-inline -fsanitize-address -o
hello.nonfinal.pexe hello.c
Silly question: Should you add -fno-inline if -fsanitize-address is specified.

If both are necessary, the script should add it automatically.

[Jim Stichnoth, 2016-07-14 20:42:11]

otherwise lgtm

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz-clang.py
File pydir/sz-clang.py (right):

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz-clang.py#newcode6
pydir/sz-clang.py:6: sz_driver.run(False)
I don't know if this is valid or reasonable python, but if you call something
like this:
  sz_driver.run(is_cpp=False)
then it become more self-documenting.

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz_driver.py
File pydir/sz_driver.py (right):

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz_driver.py#newc...
pydir/sz_driver.py:10: macros = (
https://www.chromium.org/chromium-os/python-style-guidelines#TOC-Official-Sty...

says use an indent of 2 spaces, not 4.

Subzero has some "legacy" scripts that use 4 spaces, but for new files, it would
be nice to use 2.

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz_driver.py#newc...
pydir/sz_driver.py:11: '#include <stddef.h>\n'
It would be nice if you could remove all the '\n' and then maybe add them back,
in one shot, before "return macros".

[tlively, 2016-07-14 21:30:02]

Description was changed from

==========
implemented wrapper script to replace calls to calloc()

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

to

==========
implemented wrapper script to replace calls to calloc()

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=kschimpf@google.com, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[tlively, 2016-07-14 21:30:04]

Committed patchset #3 (id:40001) manually as
f0f80654e8bafb18d795c3c77f590ee885ea753a (presubmit successful).

[tlively, 2016-07-15 01:54:25]

https://codereview.chromium.org/2145213002/diff/40001/docs/ASAN.rst
File docs/ASAN.rst (right):

https://codereview.chromium.org/2145213002/diff/40001/docs/ASAN.rst#newcode27
docs/ASAN.rst:27: sz-clang.py -fno-inline -fsanitize-address -o
hello.nonfinal.pexe hello.c
On 2016/07/14 20:36:29, Karl wrote:
> Silly question: Should you add -fno-inline if -fsanitize-address is specified.
> 
> If both are necessary, the script should add it automatically.

Done.

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz-clang.py
File pydir/sz-clang.py (right):

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz-clang.py#newcode6
pydir/sz-clang.py:6: sz_driver.run(False)
On 2016/07/14 20:42:11, stichnot wrote:
> I don't know if this is valid or reasonable python, but if you call something
> like this:
>   sz_driver.run(is_cpp=False)
> then it become more self-documenting.

Done.

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz_driver.py
File pydir/sz_driver.py (right):

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz_driver.py#newc...
pydir/sz_driver.py:10: macros = (
On 2016/07/14 20:42:11, stichnot wrote:
>
https://www.chromium.org/chromium-os/python-style-guidelines#TOC-Official-Sty...
> 
> says use an indent of 2 spaces, not 4.
> 
> Subzero has some "legacy" scripts that use 4 spaces, but for new files, it
would
> be nice to use 2.

Decided against this change to maintain consistency within directory.

https://codereview.chromium.org/2145213002/diff/40001/pydir/sz_driver.py#newc...
pydir/sz_driver.py:11: '#include <stddef.h>\n'
On 2016/07/14 20:42:11, stichnot wrote:
> It would be nice if you could remove all the '\n' and then maybe add them
back,
> in one shot, before "return macros".

Done.