Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2145193002: Fix a bug in the Clamp in X direction tiling. (Closed)

Created:
4 years, 5 months ago by herb_g
Modified:
4 years, 5 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix a bug in the Clamp in X direction tiling. The code mixed up which end of the span was cut and preserved in the sequence of span breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145193002 Committed: https://skia.googlesource.com/skia/+/494c2b6fa125d85d99fb6e9b479f21f4f76c32bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/core/SkLinearBitmapPipeline_tile.h View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
herb_g
I guess this code was never run, because this was clearly wrong. Tested by inspection ...
4 years, 5 months ago (2016-07-13 21:45:43 UTC) #3
mtklein_C
lgtm
4 years, 5 months ago (2016-07-14 21:49:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145193002/1
4 years, 5 months ago (2016-07-14 21:49:54 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:50:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/494c2b6fa125d85d99fb6e9b479f21f4f76c32bb

Powered by Google App Engine
This is Rietveld 408576698