Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 214513011: HTMLLinkElement should not run script inside ::insertedInto (Closed)

Created:
6 years, 8 months ago by esprehn
Modified:
6 years, 8 months ago
CC:
blink-reviews, dglazkov+blink, gavinp+prerender_chromium.org, adamk+blink_chromium.org
Visibility:
Public.

Description

HTMLLinkElement should not run script inside ::insertedInto This was done in r165624 but was wrong, you cannot ever synchronously dispatch the load or error event from inside didFinish since it means you run can end up running script inside ::insertedInto. It's not clear from the bug what the issue was, but the timing in the test that I updated was also wrong since it had <link> elements firing their load events synchronously while parsing. There might be a real timing bug in imports, but firing the event synchronously inside ::didFinish() isn't how to fix it. BUG=336113, 357435, 357445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M LayoutTests/fast/html/imports/import-events-inline.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
esprehn
6 years, 8 months ago (2014-03-28 01:44:26 UTC) #1
Hajime Morrita
LGTM. Could you rather file a bug for the order thing and mark the test ...
6 years, 8 months ago (2014-03-28 02:00:47 UTC) #2
esprehn
On 2014/03/28 02:00:47, morrita1 wrote: > LGTM. > Could you rather file a bug for ...
6 years, 8 months ago (2014-03-28 02:02:28 UTC) #3
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 8 months ago (2014-03-28 03:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/214513011/1
6 years, 8 months ago (2014-03-28 03:49:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 03:59:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-03-28 03:59:56 UTC) #7
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 8 months ago (2014-03-28 04:03:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/214513011/1
6 years, 8 months ago (2014-03-28 04:03:21 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 04:57:54 UTC) #10
Message was sent while issue was closed.
Change committed as 170268

Powered by Google App Engine
This is Rietveld 408576698