Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: mojo/service_manager/service_manager.h

Issue 214513009: Change ServiceManager::SetLoaderForUrl() to SetLoaderForScheme() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep both SetLoaderForURL() and SetLoaderForScheme() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/service_manager/service_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/service_manager/service_manager.h
diff --git a/mojo/service_manager/service_manager.h b/mojo/service_manager/service_manager.h
index cf4c3854b698e58023223adaa8819bddb6fa5b13..513c792744bc2a58a82f30730920c0379f112598 100644
--- a/mojo/service_manager/service_manager.h
+++ b/mojo/service_manager/service_manager.h
@@ -45,28 +45,40 @@ class MOJO_SERVICE_MANAGER_EXPORT ServiceManager {
// Returns a shared instance, creating it if necessary.
static ServiceManager* GetInstance();
- // Sets the default Loader to be used if not overridden by SetLoaderForURL().
+ // Loads a service if necessary and establishes a new client connection.
+ void Connect(const GURL& url, ScopedMessagePipeHandle client_handle);
+
+ // Sets the default Loader to be used if not overridden by
+ // SetLoaderForURL() or SetLoaderForScheme().
// Does not take ownership of |loader|.
void set_default_loader(ServiceLoader* loader) { default_loader_ = loader; }
// Sets a Loader to be used for a specific url.
// Does not take ownership of |loader|.
- void SetLoaderForURL(ServiceLoader* loader, const GURL& gurl);
- // Returns the Loader to use for a url (using default if not overridden.)
- ServiceLoader* GetLoaderForURL(const GURL& gurl);
- // Loads a service if necessary and establishes a new client connection.
- void Connect(const GURL& url, ScopedMessagePipeHandle client_handle);
+ void SetLoaderForURL(ServiceLoader* loader, const GURL& url);
+ // Sets a Loader to be used for a specific url scheme.
+ // Does not take ownership of |loader|.
+ void SetLoaderForScheme(ServiceLoader* loader, const std::string& scheme);
private:
class ServiceFactory;
+ typedef std::map<std::string, ServiceLoader*> SchemeToLoaderMap;
+ typedef std::map<GURL, ServiceLoader*> URLToLoaderMap;
+ typedef std::map<GURL, ServiceFactory*> URLToServiceFactoryMap;
+
+ // Returns the Loader to use for a url (using default if not overridden.)
+ // The preference is to use a loader that's been specified for an url first,
+ // then one that's been specified for a scheme, then the default.
+ ServiceLoader* GetLoaderForURL(const GURL& url);
// Removes a ServiceFactory when it no longer has any connections.
void OnServiceFactoryError(ServiceFactory* service_factory);
+ // Loader management.
+ URLToLoaderMap url_to_loader_;
+ SchemeToLoaderMap scheme_to_loader_;
ServiceLoader* default_loader_;
- typedef std::map<GURL, ServiceFactory*> ServiceFactoryMap;
- ServiceFactoryMap url_to_service_factory_;
- typedef std::map<GURL, ServiceLoader*> LoaderMap;
- LoaderMap url_to_loader_;
+
+ URLToServiceFactoryMap url_to_service_factory_;
DISALLOW_COPY_AND_ASSIGN(ServiceManager);
};
« no previous file with comments | « no previous file | mojo/service_manager/service_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698