Issue 214513009: Change ServiceManager::SetLoaderForUrl() to SetLoaderForScheme()

Issue 214513009: Change ServiceManager::SetLoaderForUrl() to SetLoaderForScheme() (Closed)

Created:
6 years, 9 months ago by DaveMoore

Modified:
6 years, 9 months ago

Reviewers:
darin (slow to review), viettrungluu

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change ServiceManager::SetLoaderForUrl() to SetLoaderForScheme() BUG=None R=viettrungluu@chromium.org, viettrungluu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260253

Patch Set 2 : Leave GetLoaderForURL() as is #

Patch Set 3 : Leave GetLoaderForURL() as is #

Total comments: 1

Patch Set 4 : Keep both SetLoaderForURL() and SetLoaderForScheme() #

Patch Set 5 : Keep both SetLoaderForURL() and SetLoaderForScheme() #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -26 lines)			Patch
M	mojo/service_manager/service_manager.h	View	1 2 3 4	1 chunk	+22 lines, -10 lines	0 comments	Download
M	mojo/service_manager/service_manager.cc	View	1 2 3	4 chunks	+27 lines, -16 lines	0 comments	Download
M	mojo/service_manager/service_manager_unittest.cc	View	1 2 3 4	2 chunks	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

https://codereview.chromium.org/214513009/diff/40001/mojo/service_manager/service_manager.h File mojo/service_manager/service_manager.h (right): https://codereview.chromium.org/214513009/diff/40001/mojo/service_manager/service_manager.h#newcode52 mojo/service_manager/service_manager.h:52: // Sets a Loader to be used for a ...

6 years, 9 months ago (2014-03-27 23:33:41 UTC) #4

DaveMoore

6 years, 9 months ago (2014-03-28 20:15:12 UTC) #9

Message was sent while issue was closed.

Committed patchset #5 manually as r260253 (presubmit successful).

Expand Messages | Collapse Messages