Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 214513008: Add layout test for table repainting. (Closed)

Created:
6 years, 9 months ago by dsinclair
Modified:
6 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews
Visibility:
Public.

Description

Add layout test for table repainting. When the background of the table row is changed we repaint the entire table. This CL adds a layout test showing the issue. BUG=357291 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A LayoutTests/fast/repaint/table-row-bg-change.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/table-row-bg-change-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dsinclair
PTAL. This adds a simple layout test to show the repaint issue.
6 years, 9 months ago (2014-03-27 21:13:46 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-27 21:15:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/214513008/1
6 years, 9 months ago (2014-03-27 21:15:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:33:07 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:33:07 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 22:37:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/214513008/1
6 years, 9 months ago (2014-03-27 22:38:35 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 23:41:53 UTC) #8
Message was sent while issue was closed.
Change committed as 170221

Powered by Google App Engine
This is Rietveld 408576698