Issue 214513006: Add Ozone stub implementations for NativeDisplayDelegate and TouchscreenDelegate

Issue 214513006: Add Ozone stub implementations for NativeDisplayDelegate and TouchscreenDelegate (Closed)

Created:
6 years, 9 months ago by dnicoara

Modified:
6 years, 9 months ago

Reviewers:
rjkroege, Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add Ozone stub implementations for NativeDisplayDelegate and TouchscreenDelegate As a first step, I'm introducing stub implementations such that the Ozone path can be exercised. In future CLs I plan on removing ifdefs limiting the use of OutputConfigurator to X11 and add actual functionality to the delegates. BUG=333413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260214

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Patch Set 3 : Rebased #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -1 line)			Patch
M	ui/display/chromeos/output_configurator.cc	View	1	2 chunks	+21 lines, -1 line	0 comments	Download
A	ui/display/chromeos/ozone/native_display_delegate_ozone.h	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
A	ui/display/chromeos/ozone/native_display_delegate_ozone.cc	View		1 chunk	+95 lines, -0 lines	0 comments	Download
A	ui/display/chromeos/ozone/touchscreen_delegate_ozone.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	ui/display/chromeos/ozone/touchscreen_delegate_ozone.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	ui/display/display.gyp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dnicoara

PTAL https://codereview.chromium.org/214513006/diff/1/ui/display/chromeos/ozone/native_display_delegate_ozone.cc File ui/display/chromeos/ozone/native_display_delegate_ozone.cc (right): https://codereview.chromium.org/214513006/diff/1/ui/display/chromeos/ozone/native_display_delegate_ozone.cc#newcode41 ui/display/chromeos/ozone/native_display_delegate_ozone.cc:41: return std::vector<ui::DisplaySnapshot*>(); This will force Ash to create ...

6 years, 9 months ago (2014-03-27 19:33:59 UTC) #1

Daniel Erat

lgtm https://codereview.chromium.org/214513006/diff/1/ui/display/chromeos/ozone/native_display_delegate_ozone.h File ui/display/chromeos/ozone/native_display_delegate_ozone.h (right): https://codereview.chromium.org/214513006/diff/1/ui/display/chromeos/ozone/native_display_delegate_ozone.h#newcode46 ui/display/chromeos/ozone/native_display_delegate_ozone.h:46: nit: delete blank line

6 years, 9 months ago (2014-03-27 20:06:20 UTC) #2

dnicoara

https://codereview.chromium.org/214513006/diff/1/ui/display/chromeos/ozone/native_display_delegate_ozone.h File ui/display/chromeos/ozone/native_display_delegate_ozone.h (right): https://codereview.chromium.org/214513006/diff/1/ui/display/chromeos/ozone/native_display_delegate_ozone.h#newcode46 ui/display/chromeos/ozone/native_display_delegate_ozone.h:46: On 2014/03/27 20:06:20, Daniel Erat wrote: > nit: delete ...

6 years, 9 months ago (2014-03-27 21:17:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/214513006/40001

6 years, 9 months ago (2014-03-28 13:52:48 UTC) #6

Message was sent while issue was closed.

Change committed as 260214

Expand Messages | Collapse Messages