Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2145123002: [DevTools] Fix V8_inspector compilation with Node (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix V8_inspector compilation with Node TBR=dgozman@chromium.org Committed: https://crrev.com/63bf1fba9e7f5444b0aec7a56b77f72be99c67a1 Cr-Commit-Position: refs/heads/master@{#405271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8InternalValueType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kozy
Dmitry, ptal
4 years, 5 months ago (2016-07-13 18:42:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145123002/1
4 years, 5 months ago (2016-07-13 18:59:42 UTC) #4
dgozman
lgtm
4 years, 5 months ago (2016-07-13 19:20:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:22:26 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:24:21 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/63bf1fba9e7f5444b0aec7a56b77f72be99c67a1
Cr-Commit-Position: refs/heads/master@{#405271}

Powered by Google App Engine
This is Rietveld 408576698