Request the Identity API's Uber Token without a Channel ID

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 247 matching lines @@
   virtual policy::URLBlacklist::URLBlacklistState GetURLBlacklistState(
       const GURL& url) const;
 
   // Returns the predictor service for this Profile. Returns nullptr if there is
   // no Predictor, as is the case with OffTheRecord profiles.
   virtual chrome_browser_net::Predictor* GetPredictor();
 
   // Get platform ClientCertStore. May return nullptr.
   std::unique_ptr<net::ClientCertStore> CreateClientCertStore();
 
- protected:
-  // A URLRequestContext for media that owns its HTTP factory, to ensure
-  // it is deleted.
-  class MediaRequestContext : public net::URLRequestContext {
-   public:
-    MediaRequestContext();
-
-    void SetHttpTransactionFactory(
-        std::unique_ptr<net::HttpTransactionFactory> http_factory);
-
-   private:
-    ~MediaRequestContext() override;
-
-    std::unique_ptr<net::HttpTransactionFactory> http_factory_;
-  };
-
   // A URLRequestContext for apps that owns its cookie store and HTTP factory,
   // to ensure they are deleted.
   class AppRequestContext : public net::URLRequestContext {
    public:
     AppRequestContext();
 
     void SetCookieStore(std::unique_ptr<net::CookieStore> cookie_store);
     void SetChannelIDService(
         std::unique_ptr<net::ChannelIDService> channel_id_service);
     void SetHttpNetworkSession(
         std::unique_ptr<net::HttpNetworkSession> http_network_session);
     void SetHttpTransactionFactory(
         std::unique_ptr<net::HttpTransactionFactory> http_factory);
     void SetJobFactory(std::unique_ptr<net::URLRequestJobFactory> job_factory);
 
    private:
     ~AppRequestContext() override;
 
     std::unique_ptr<net::CookieStore> cookie_store_;
     std::unique_ptr<net::ChannelIDService> channel_id_service_;
     std::unique_ptr<net::HttpNetworkSession> http_network_session_;
     std::unique_ptr<net::HttpTransactionFactory> http_factory_;
     std::unique_ptr<net::URLRequestJobFactory> job_factory_;
   };
 
+ protected:

[anthonyvd, 2016/07/13 18:36:08]

This diff is pretty bad. This is making AppRequestContext public.

[nharper, 2016/07/13 20:04:47]

The reason for using the AppRequestContext was to have something to hold
ownership of the URLRequestContext's pointers. I think you could use an
URLRequestContext directly and have the GaiaWebAuthFlow hold ownership (or use
an URLRequestContextStorage to hold ownership of the new objects).

[anthonyvd, 2016/07/13 20:33:46]

I see. I initially tried to use it because it's not possible to set
HttpNetworkSession on net::URLRequestContext. Turns out it's
HttpTransactionFactory that ties all of this together so using AppRequestContext
was irrelevant.

Done.

+  // A URLRequestContext for media that owns its HTTP factory, to ensure
+  // it is deleted.
+  class MediaRequestContext : public net::URLRequestContext {
+   public:
+    MediaRequestContext();
+
+    void SetHttpTransactionFactory(
+        std::unique_ptr<net::HttpTransactionFactory> http_factory);
+
+   private:
+    ~MediaRequestContext() override;
+
+    std::unique_ptr<net::HttpTransactionFactory> http_factory_;
+  };
+
   // Created on the UI thread, read on the IO thread during ProfileIOData lazy
   // initialization.
   struct ProfileParams {
     ProfileParams();
     ~ProfileParams();
 
     base::FilePath path;
     IOThread* io_thread;
     scoped_refptr<content_settings::CookieSettings> cookie_settings;
     scoped_refptr<HostContentSettingsMap> host_content_settings_map;
@@ skipping 306 matching lines @@
   mutable std::unique_ptr<certificate_transparency::TreeStateTracker>
       ct_tree_tracker_;
   mutable base::Closure ct_tree_tracker_unregistration_;
 
   const Profile::ProfileType profile_type_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_