Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2145063003: Updates in preparation of wrapper script (Closed)

Created:
4 years, 5 months ago by tlively
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updates in preparation of wrapper script BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f6c41e46ac899f3bf606dd824890eeedefa81750

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added extra test #

Patch Set 3 : minor fix to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M pydir/utils.py View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/szrt_asan.c View 2 chunks +8 lines, -0 lines 0 comments Download
M src/IceASanInstrumentation.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
A tests_lit/asan_tests/func_ptr.ll View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tlively
4 years, 5 months ago (2016-07-13 21:13:55 UTC) #2
Karl
lgtm https://codereview.chromium.org/2145063003/diff/1/src/IceASanInstrumentation.cpp File src/IceASanInstrumentation.cpp (right): https://codereview.chromium.org/2145063003/diff/1/src/IceASanInstrumentation.cpp#newcode70 src/IceASanInstrumentation.cpp:70: (FuncBlackList.count(FuncName) == 0 && FuncName.find(ASanPrefix) != 0); run ...
4 years, 5 months ago (2016-07-13 21:17:57 UTC) #3
tlively
https://codereview.chromium.org/2145063003/diff/1/src/IceASanInstrumentation.cpp File src/IceASanInstrumentation.cpp (right): https://codereview.chromium.org/2145063003/diff/1/src/IceASanInstrumentation.cpp#newcode70 src/IceASanInstrumentation.cpp:70: (FuncBlackList.count(FuncName) == 0 && FuncName.find(ASanPrefix) != 0); On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 21:26:24 UTC) #4
tlively
4 years, 5 months ago (2016-07-13 21:43:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f6c41e46ac899f3bf606dd824890eeedefa81750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698