Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2145063002: Reland of Make components source_sets on Android. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Reid Kleckner
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make components source_sets on Android. (patchset #1 id:1 of https://codereview.chromium.org/2151523002/ ) Reason for revert: Didn't help. Original issue's description: > Revert of Make components source_sets on Android. (patchset #1 id:1 of https://codereview.chromium.org/2137023003/ ) > > Reason for revert: > Speculative, might've broke llvm_force_head_revision=true builds (see comment on the original review). > > Original issue's description: > > Make components source_sets on Android. > > > > There was a perf regression reported when components were changed from source sets to static libraries in the non-component build. This patch switches back to source sets on Android only to see what happens to thread_times.key_silk_cases and the build performance. > > > > BUG=619593 > > > > Committed: https://crrev.com/89248dc70996f9927292a7fee6911715464e1643 > > Cr-Commit-Position: refs/heads/master@{#405056} > > TBR=dpranke@chromium.org,brettw@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=619593 > > Committed: https://crrev.com/aa5466df6e58dd54bc1dd1a5192f2c52ebf6ff29 > Cr-Commit-Position: refs/heads/master@{#405152} TBR=dpranke@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619593 Committed: https://crrev.com/edc7aa53ed38bbd5fbe330bab79f4ac9995321ae Cr-Commit-Position: refs/heads/master@{#405159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
Created Reland of Make components source_sets on Android.
4 years, 5 months ago (2016-07-13 15:29:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145063002/1
4 years, 5 months ago (2016-07-13 15:30:06 UTC) #3
commit-bot: I haz the power
Failed to apply the patch.
4 years, 5 months ago (2016-07-13 15:32:43 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 15:32:58 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/edc7aa53ed38bbd5fbe330bab79f4ac9995321ae Cr-Commit-Position: refs/heads/master@{#405159}
4 years, 5 months ago (2016-07-13 15:33:30 UTC) #9
Dirk Pranke
4 years, 5 months ago (2016-07-13 16:31:56 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698