Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2145043002: Increase allowed percentage of pixels that differ in ImageBackgroundFilter.BackgroundFilterRotated_… (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, csmartdalton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase allowed percentage of pixels that differ in ImageBackgroundFilter.BackgroundFilterRotated_GL test The old value was 3.1% and on Windows a Skia change causes slightly more pixels to be different. It is increased to 4%. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/eedcdfa43bfa4e5e61cecf52f4f52e10d6a9c25e Cr-Commit-Position: refs/heads/master@{#405265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
bsalomon
My previous change wasn't quite sufficient for Windows.
4 years, 5 months ago (2016-07-13 14:51:06 UTC) #4
enne (OOO)
Sorry for our renderer tests causing you pain. We try to have a lot of ...
4 years, 5 months ago (2016-07-13 17:59:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145043002/1
4 years, 5 months ago (2016-07-13 18:14:52 UTC) #7
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is ...
4 years, 5 months ago (2016-07-13 19:33:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:17:27 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:17:55 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:19:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eedcdfa43bfa4e5e61cecf52f4f52e10d6a9c25e
Cr-Commit-Position: refs/heads/master@{#405265}

Powered by Google App Engine
This is Rietveld 408576698