Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2145003004: Add ScopedAllowIO to allow get of FILE_EXE etc paths from non-IO-thread. (Closed)

Created:
4 years, 5 months ago by Wez
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, Mark Seaborn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedAllowIO to allow get of FILE_EXE etc paths from non-IO-thread. PathService::Get() is treated as safe-to-call from any thread, but PathProviderMac(FILE_EXE,...) looks up the NSExecutable path, and translates it from relative to absolute using base::MakeAbsoluteFilePath(), which asserts that IO is allowed on the calling thread. This was being hit by code in NaClBrowser in developers' local debug builds. As per the discussion on crbug.com/259796, the one-off cost of this IO (given PathService then caches the result) seems acceptable. NOPRESUBMIT=true BUG=373477, 259796 Committed: https://crrev.com/adb3c21551b2f0f7a92878a03cc89782c6b114c4 Cr-Commit-Position: refs/heads/master@{#405577}

Patch Set 1 #

Patch Set 2 : Add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/base_paths_mac.mm View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Wez
PTAL
4 years, 5 months ago (2016-07-13 23:33:39 UTC) #2
dcheng
lgtm since jam seems ok with this
4 years, 5 months ago (2016-07-14 03:43:36 UTC) #4
Wez
Hmmm, and yet... how to land, since PRESUBMIT is convinced it's Bad, and Wrong? :-/ ...
4 years, 5 months ago (2016-07-14 09:03:24 UTC) #5
dcheng
On 2016/07/14 09:03:24, Wez wrote: > Hmmm, and yet... how to land, since PRESUBMIT is ...
4 years, 5 months ago (2016-07-14 09:19:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145003004/20001
4 years, 5 months ago (2016-07-14 20:26:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 21:25:48 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:26:09 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:28:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/adb3c21551b2f0f7a92878a03cc89782c6b114c4
Cr-Commit-Position: refs/heads/master@{#405577}

Powered by Google App Engine
This is Rietveld 408576698