Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2145003002: HTMLViewSourceParser should pumpTokenizer only if not detached (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTMLViewSourceParser should pumpTokenizer only if not detached Speculative crash fix for non-reproducible clusterfuzz case. BUG=624903 Committed: https://crrev.com/00435c119e19ce53b1b07f337c568eee4ffc7521 Cr-Commit-Position: refs/heads/master@{#405073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-13 06:33:42 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-07-13 06:34:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145003002/1
4 years, 5 months ago (2016-07-13 06:36:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:01:12 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:03:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/00435c119e19ce53b1b07f337c568eee4ffc7521
Cr-Commit-Position: refs/heads/master@{#405073}

Powered by Google App Engine
This is Rietveld 408576698