CustomElements: insert a node

CustomElements: insert a node

Added test for Step 6.5.2.1
If inclusiveDescendant is custom, then enqueue a custom element
callback reaction with inclusiveDescendant, callback name
"connectedCallback", and an empty argument list.

BUG=594918
Committed: https://crrev.com/4d0c35ab4205fd1cb8399398af441acffb77ddb8
Cr-Commit-Position: refs/heads/master@{#406520}

[davaajav, 2016-07-13 05:07:40]

davaajav@google.com changed reviewers:
+ dominicc@chromium.org, kojii@chromium.org

[davaajav, 2016-07-13 05:07:40]

PTL

[dominicc (has gone to gerrit), 2016-07-13 06:19:06]

lgtm

Really good. I will LGTM this, but I have a few minor comments inline. Let me
know when you have addressed those and we'll commit this.

https://codereview.chromium.org/2144993002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html
(right):

https://codereview.chromium.org/2144993002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:19:
constructor() { super(); }
You can omit this line; I think an ES6 class gets something like this by
default. You only need to write the constructor if you want to do something
different to this.

https://codereview.chromium.org/2144993002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:28:
assert_equals(invocations.length, 1, 'connectedCallback should be invoked only
once');
Could you also assert the length is 1 before line 27 as a sanity check? It makes
it clearer that this is checking there's no *additional* invocation of the
constructor at line 27.

https://codereview.chromium.org/2144993002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/custom-elements/spec/insert-a-node-try-to-upgrade.html:29:
assert_array_equals(invocations[0], ['connected', element], 'insierting "custom"
element should enqueue a connectedCallback reaction');
Spelling--inserting

[dominicc (has gone to gerrit), 2016-07-13 06:19:20]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 06:19:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 07:36:51]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 07:36:52]

Dry run: This issue passed the CQ dry run.

[davaajav, 2016-07-13 08:18:52]

PTL

Decided to appendChild to head, for now.

[dominicc (has gone to gerrit), 2016-07-19 01:26:17]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-07-19 01:26:18]

lgtm

[commit-bot: I haz the power, 2016-07-19 01:27:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 04:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 04:04:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dominicc (has gone to gerrit), 2016-07-20 07:28:27]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2016-07-20 07:28:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:49:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 08:49:55]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 08:51:17]

Description was changed from

==========
CustomElements: insert a node

Added test for Step 6.5.2.1
If inclusiveDescendant is custom, then enqueue a custom element
callback reaction with inclusiveDescendant, callback name
"connectedCallback", and an empty argument list.

BUG=594918
==========

to

==========
CustomElements: insert a node

Added test for Step 6.5.2.1
If inclusiveDescendant is custom, then enqueue a custom element
callback reaction with inclusiveDescendant, callback name
"connectedCallback", and an empty argument list.

BUG=594918

Committed: https://crrev.com/4d0c35ab4205fd1cb8399398af441acffb77ddb8
Cr-Commit-Position: refs/heads/master@{#406520}
==========

[commit-bot: I haz the power, 2016-07-20 08:51:18]

Patchset 3 (id:??) landed as
https://crrev.com/4d0c35ab4205fd1cb8399398af441acffb77ddb8
Cr-Commit-Position: refs/heads/master@{#406520}