Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Unified Diff: components/neterror/resources/offline.js

Issue 2144933002: Fix the T-Rex easter egg on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/neterror/resources/offline.js
diff --git a/components/neterror/resources/offline.js b/components/neterror/resources/offline.js
index 005f4f3ae20dc570369df092d783a9e5bfec0e13..a1a3cd3c8b28c59eedf34003ab5eae56e957f31d 100644
--- a/components/neterror/resources/offline.js
+++ b/components/neterror/resources/offline.js
@@ -292,7 +292,16 @@ Runner.prototype = {
this.spriteDef = Runner.spriteDefinition.LDPI;
}
- this.init();
+ if(!Runner.imageSprite.complete) {
Eugene But (OOO till 7-30) 2016/07/13 05:28:57 Space after |if|
kkhorimoto 2016/07/13 17:54:53 Done.
+ // If the images are not yet loaded, add a listener.
+ Runner.imageSprite.runner = this;
+
+ Runner.imageSprite.onload = function() {
+ this.runner.init();
+ }
+ } else {
+ this.init();
+ }
},
/**
@@ -660,7 +669,9 @@ Runner.prototype = {
if (!this.activated) {
this.loadSounds();
this.activated = true;
- errorPageController.trackEasterEgg();
+ if (window.errorPageController) {
Eugene But (OOO till 7-30) 2016/07/13 05:28:57 Optional NIT: Maybe s/window.errorPageController/e
kkhorimoto 2016/07/13 17:54:53 Done.
+ errorPageController.trackEasterEgg();
+ }
}
if (!this.tRex.jumping && !this.tRex.ducking) {

Powered by Google App Engine
This is Rietveld 408576698