Fix the T-Rex easter egg on iOS.

components/neterror/resources/offline.js

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 (function() {
 'use strict';
 /**
  * T-Rex runner.
  * @param {string} outerContainerId Outer containing element id.
  * @param {Object} opt_config
  * @constructor
@@ skipping 274 matching lines @@
    */
   loadImages: function() {
     if (IS_HIDPI) {
       Runner.imageSprite = document.getElementById('offline-resources-2x');
       this.spriteDef = Runner.spriteDefinition.HDPI;
     } else {
       Runner.imageSprite = document.getElementById('offline-resources-1x');
       this.spriteDef = Runner.spriteDefinition.LDPI;
     }
 
-    this.init();
+    if (!Runner.imageSprite.complete) {

[edwardjung, 2016/07/18 10:37:11]

Do a positive check for the 'complete' property.

if (Runner.imageSprite.complete) {
   …  
} else {
   …
}

[kkhorimoto, 2016/07/20 01:18:29]

Done.

+      // If the images are not yet loaded, add a listener.
+      Runner.imageSprite.runner = this;
+
+      Runner.imageSprite.onload = function() {
+        this.runner.init();
+      }

[edwardjung, 2016/07/18 10:37:11]

I would use the addEventListener style of attaching a listener that is used
everywhere else. Cleaner and you can bind 'this' to the function at the same
time:

Runner.imageSprite.addEventListener(Runner.events.LOAD, this.init.bind(this));

[kkhorimoto, 2016/07/20 01:18:29]

Done.

+    } else {
+      this.init();
+    }
   },
 
   /**
    * Load and decode base 64 encoded sounds.
    */
   loadSounds: function() {
     if (!IS_IOS) {
       this.audioContext = new AudioContext();
 
       var resourceTemplate =
@@ skipping 347 matching lines @@
     if (IS_MOBILE && this.activated) {
       e.preventDefault();
     }
 
     if (e.target != this.detailsButton) {
       if (!this.crashed && (Runner.keycodes.JUMP[e.keyCode] ||
            e.type == Runner.events.TOUCHSTART)) {
         if (!this.activated) {
           this.loadSounds();
           this.activated = true;
-          errorPageController.trackEasterEgg();
+          if (errorPageController) {
+            errorPageController.trackEasterEgg();
+          }

[edwardjung, 2016/07/18 10:37:11]

Will there ever be an instance where errorPageController won't exist at this
point? We always want to track the easter egg activations.

Regardless, the check should be:

if (window.errorPageController) {
 …
}

As otherwise this would throw a reference error if errorPageController doesn't
exist.

[kkhorimoto, 2016/07/20 01:18:29]

errorPageController is consistently nil on iOS.  Somehow my previous check of
"if (errorPageController)" wasn't throwing an exception when I uploaded this
first patch, but now it does, so the "window" portion is added.  I can't seem to
find where this variable is set though; from your comment it seems like it is
probably a bug that it is nil here.

[edwardjung, 2016/07/20 21:37:57]

errorPageController is exposed from NetErrorPageController::Install() as a
global so it should exist. 
https://cs.chromium.org/chromium/src/chrome/renderer/net/net_error_page_contr...

This used to work without this check, so I'm wondering if something changed in
the transition to WKWebView? 

         }
 
         if (!this.tRex.jumping && !this.tRex.ducking) {
           this.playSound(this.soundFx.BUTTON_PRESS);
           this.tRex.startJump(this.currentSpeed);
         }
       }
 
       if (this.crashed && e.type == Runner.events.TOUCHSTART &&
           e.currentTarget == this.containerEl) {
@@ skipping 2006 matching lines @@
 
   /**
    * Add a new cloud to the horizon.
    */
   addCloud: function() {
     this.clouds.push(new Cloud(this.canvas, this.spritePos.CLOUD,
         this.dimensions.WIDTH));
   }
 };
 })();