Introduce rolp, rorp, rclp, rcrp, shlp, shrp and sarp for x64 port

Introduce rolp, rorp, rclp, rcrp, shlp, shrp and sarp for x64 port

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20320

[haitao.feng, 2014-03-27 09:09:50]

PTAL. Shift instructions are different with the others as we have to handle the
"_cl" suffix.

[Toon Verwaest, 2014-03-27 16:12:42]

LGTM, I'm just not a 100% sure about the extensions you used when translating
operations.

https://codereview.chromium.org/214493002/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/214493002/diff/1/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:3118: __ shrp(count, Immediate(kPointerSizeLog2));
shrl?

https://codereview.chromium.org/214493002/diff/1/src/x64/ic-x64.cc
File src/x64/ic-x64.cc (right):

https://codereview.chromium.org/214493002/diff/1/src/x64/ic-x64.cc#newcode424
src/x64/ic-x64.cc:424: __ shrp(rcx, Immediate(KeyedLookupCache::kMapHashShift));
shrl?

https://codereview.chromium.org/214493002/diff/1/src/x64/ic-x64.cc#newcode425
src/x64/ic-x64.cc:425: __ movl(rdi, FieldOperand(rax,
String::kHashFieldOffset));
shrl?

https://codereview.chromium.org/214493002/diff/1/test/cctest/test-macro-assem...
File test/cctest/test-macro-assembler-x64.cc (right):

https://codereview.chromium.org/214493002/diff/1/test/cctest/test-macro-assem...
test/cctest/test-macro-assembler-x64.cc:1519: __ shlq(index.reg,
Immediate(index.scale));
shlp? Same for below?

[haitao.feng, 2014-03-28 04:14:39]

Good catch! Thanks for the review, Toon.

Currently I am using a script
(https://github.com/fenghaitao/v8/blob/x32/tools/generate-x64-sources.py) to
generate the instruction##q to instruction##p replacement at
https://github.com/fenghaitao/v8/blob/x32/tools/generate-x64-sources.py#L127.
This script is adapted from the x32 code generator which replace the
instruction##q with instruction##l originally. I still keep that script to
replace instruction##q with instruction##p. The current instruction##q is
prefixed with __k (63 occurrences).

I have not examined the code thoroughly to see some instruction##p could be
replaced with instruction##l, if so, we might be able to reduce some code size
by not emitting REX.W.

https://codereview.chromium.org/214493002/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/214493002/diff/1/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:3118: __ shrp(count, Immediate(kPointerSizeLog2));
On 2014/03/27 16:12:42, Toon Verwaest wrote:
> shrl?

Done.

https://codereview.chromium.org/214493002/diff/1/src/x64/ic-x64.cc
File src/x64/ic-x64.cc (right):

https://codereview.chromium.org/214493002/diff/1/src/x64/ic-x64.cc#newcode424
src/x64/ic-x64.cc:424: __ shrp(rcx, Immediate(KeyedLookupCache::kMapHashShift));
On 2014/03/27 16:12:42, Toon Verwaest wrote:
> shrl?

Done.

https://codereview.chromium.org/214493002/diff/1/src/x64/ic-x64.cc#newcode425
src/x64/ic-x64.cc:425: __ movl(rdi, FieldOperand(rax,
String::kHashFieldOffset));
On 2014/03/27 16:12:42, Toon Verwaest wrote:
> shrl?

Done.

https://codereview.chromium.org/214493002/diff/1/test/cctest/test-macro-assem...
File test/cctest/test-macro-assembler-x64.cc (right):

https://codereview.chromium.org/214493002/diff/1/test/cctest/test-macro-assem...
test/cctest/test-macro-assembler-x64.cc:1519: __ shlq(index.reg,
Immediate(index.scale));
I have tried to keep the instruction##q name in the test-assember-x64.cc,
test-macro-assember-x64.cc. Those files currently are not compiled for x32. I
could change them into instruction##p in the future.

[haitao.feng, 2014-03-28 04:55:25]

Committed patchset #2 manually as r20320 (presubmit successful).