Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2144923002: DevTools: remove the ComputedStyles -> Styles pane dependency. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove the ComputedStyles -> Styles pane dependency. BUG=627306 Committed: https://crrev.com/d5a7c845d993b6448b0842380f4a4c559e67153b Cr-Commit-Position: refs/heads/master@{#405311}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebaselined #

Messages

Total messages: 11 (5 generated)
pfeldman
4 years, 5 months ago (2016-07-13 00:40:22 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2144923002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js File third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js (right): https://codereview.chromium.org/2144923002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js#newcode84 third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js:84: return new WebInspector.ElementsSidebarViewWrapperPane(WebInspector.UIString("Computed Style"), widget) while we're here: ...
4 years, 5 months ago (2016-07-13 13:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144923002/1
4 years, 5 months ago (2016-07-13 17:19:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144923002/20001
4 years, 5 months ago (2016-07-13 19:53:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 22:39:16 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:41:30 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d5a7c845d993b6448b0842380f4a4c559e67153b
Cr-Commit-Position: refs/heads/master@{#405311}

Powered by Google App Engine
This is Rietveld 408576698