chrome/browser/ui/views/location_bar/icon_label_bubble_view.h - Issue 2144903004: New location security strings and animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 2144903004: New location security strings and animation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplified StartAnimation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

index 7676039c64b7644b432bf5098eeb3087aaeff731..f0ccaa83f994d80238803128c21bdf1402201ea3 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

@@ -32,6 +32,7 @@ class Painter;

class IconLabelBubbleView : public views::InkDropHostView {

public:

static constexpr int kTrailingPaddingPreMd = 2;

+ static constexpr int kOpenTimeMS = 150;

Peter Kasting 2016/08/18 06:24:37 Nit: Should be protected, and can be defined in th

Kevin Bailey 2016/08/18 16:09:36 Made protected, but what's the advantage of moving

Peter Kasting 2016/08/20 01:16:43 Not much, don't worry about it.

IconLabelBubbleView(int contained_image,

const gfx::FontList& font_list,