[Telemetry] Remove merge policy concept from ListOfScalarValues

[Telemetry] Remove merge policy concept from ListOfScalarValues

Until now, ListOfScalarValues has supported different "merge policies", so that
users could hypothetically pick between CONCATENATE and PICK_FIRST. In
practice, everyone just uses CONCATENATE, and the PICK_FIRST implementation is
also buggy at present, so this CL removes the concept and makes concatenation
the only way to merge lists.

BUG=chromium:624522
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/38bb5e3b7b0bd7ba85c8636d296f94783d420663

[eakuefner, 2016-07-12 21:34:34]

eakuefner@chromium.org changed reviewers:
+ aiolos@chromium.org, nednguyen@google.com

[eakuefner, 2016-07-12 21:34:35]

PTAL. I came across this dead, buggy code while working on updating
summarization to work for TBMv2.

[eakuefner, 2016-07-12 21:35:09]

The CQ bit was checked by eakuefner@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 21:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-07-12 21:59:52]

On 2016/07/12 21:34:35, eakuefner wrote:
> PTAL. I came across this dead, buggy code while working on updating
> summarization to work for TBMv2.

Where is the bug in PICK_FIRST implementation?

[commit-bot: I haz the power, 2016-07-12 22:06:36]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:06:37]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[eakuefner, 2016-07-12 22:10:16]

On 2016/07/12 at 21:59:52, nednguyen wrote:
> On 2016/07/12 21:34:35, eakuefner wrote:
> > PTAL. I came across this dead, buggy code while working on updating
> > summarization to work for TBMv2.
> 
> Where is the bug in PICK_FIRST implementation?

It doesn't take all the fields of the value: description, tir_label, etc. I
could update it and the associated tests in my patch that updates the
summarization behavior of chart JSON for TBMv2, but I'd prefer not to since this
functionality is unused.

[nednguyen, 2016-07-12 22:16:24]

lgtm
Yeah no code is best code

[aiolos (Not reviewing), 2016-07-12 22:28:56]

lgtm after you fix the tests.

[eakuefner, 2016-07-12 22:34:38]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-07-12 22:34:39]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org,
nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2144883002/#ps20001
(title: "Fix failing test")

[commit-bot: I haz the power, 2016-07-12 22:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eakuefner, 2016-07-12 22:34:46]

On 2016/07/12 at 22:28:56, aiolos wrote:
> lgtm after you fix the tests.

Done.

[commit-bot: I haz the power, 2016-07-13 00:44:07]

Description was changed from

==========
[Telemetry] Remove merge policy concept from ListOfScalarValues

Until now, ListOfScalarValues has supported different "merge policies", so that
users could hypothetically pick between CONCATENATE and PICK_FIRST. In
practice, everyone just uses CONCATENATE, and the PICK_FIRST implementation is
also buggy at present, so this CL removes the concept and makes concatenation
the only way to merge lists.

BUG=chromium:624522
==========

to

==========
[Telemetry] Remove merge policy concept from ListOfScalarValues

Until now, ListOfScalarValues has supported different "merge policies", so that
users could hypothetically pick between CONCATENATE and PICK_FIRST. In
practice, everyone just uses CONCATENATE, and the PICK_FIRST implementation is
also buggy at present, so this CL removes the concept and makes concatenation
the only way to merge lists.

BUG=chromium:624522

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-13 00:44:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...