third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py - Issue 2144873004: In rebaseline, include build number information with "test_prefix_list" dicts.

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py

Issue 2144873004: In rebaseline, include build number information with "test_prefix_list" dicts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py

index b8650b6808692f2cb24c42fd4a8d921d34385b57..a7248fc9148dd3f7c1a2e3dad1cfee25544d5386 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py

@@ -51,6 +51,7 @@ class RebaselineFromTryJobsTest(BaseTestCase):

self.git = MockSCM()

self.git.get_issue_number = lambda: 'None'

self.command._git = lambda: self.git

+ self.maxDiff = None

wkorman 2016/07/14 01:01:46 Why do we need this?

qyearsley 2016/07/14 23:53:29 We don't, this was also for debugging. (This attri

@staticmethod

def command_options(**kwargs):

@@ -73,9 +74,9 @@ class RebaselineFromTryJobsTest(BaseTestCase):

self.assertMultiLineEqual(

logs,

('Tests to rebaseline:\n'

- ' svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: MOCK Try Win\n'

- ' fast/dom/prototype-inheritance.html: MOCK Try Win\n'

- ' fast/dom/prototype-taco.html: MOCK Try Win\n'

+ ' svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: MOCK Try Win (5000)\n'

+ ' fast/dom/prototype-inheritance.html: MOCK Try Win (5000)\n'

+ ' fast/dom/prototype-taco.html: MOCK Try Win (5000)\n'

'Rebaselining fast/dom/prototype-inheritance.html\n'

'Rebaselining fast/dom/prototype-taco.html\n'

'Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html\n'))

@@ -100,9 +101,9 @@ class RebaselineFromTryJobsTest(BaseTestCase):