Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 2144873002: Support first letter navigation in Panel. (Closed)

Created:
4 years, 5 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support first letter navigation in Panel. Also, re-enables ancestry announcements in menus. This re-introduces a bug in Docs rooted with re-parenting, but it also makes reading parenting menus again within Panel. The root reparenting bug should be fixed and not worked around in ChromeVox. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f5ac898717ff2d036112a5cc5c872acef14d45b7 Cr-Commit-Position: refs/heads/master@{#406621}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
David Tseng
4 years, 5 months ago (2016-07-15 19:17:45 UTC) #5
dmazzoni
lgtm
4 years, 5 months ago (2016-07-18 04:14:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144873002/1
4 years, 5 months ago (2016-07-19 21:46:03 UTC) #9
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-19 21:46:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/203947)
4 years, 5 months ago (2016-07-19 22:33:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144873002/20001
4 years, 5 months ago (2016-07-20 17:14:49 UTC) #16
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 17:14:51 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 18:19:32 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 18:19:47 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:22:57 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5ac898717ff2d036112a5cc5c872acef14d45b7
Cr-Commit-Position: refs/heads/master@{#406621}

Powered by Google App Engine
This is Rietveld 408576698