Reuse existing paint property node is possible

third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintChunker.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 90 matching lines @@
 }
 
 TEST_F(PaintChunkerTest, BuildMultipleChunksWithSinglePropertyChanging)
 {
     PaintChunker chunker;
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransform;
-    simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
+    simpleTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
 
     chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties anotherTransform;
-    anotherTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
+    anotherTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
     chunker.updateCurrentPaintChunkProperties(nullptr, anotherTransform);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
     EXPECT_THAT(chunks, ElementsAre(
         PaintChunk(0, 2, nullptr, rootPaintChunkProperties()),
         PaintChunk(2, 3, nullptr, simpleTransform),
         PaintChunk(3, 4, nullptr, anotherTransform)));
 }
 
 TEST_F(PaintChunkerTest, BuildMultipleChunksWithDifferentPropertyChanges)
 {
     PaintChunker chunker;
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransform;
-    simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 0, 0, 0, 0, 0), FloatPoint3D(9, 8, 7));
+    simpleTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 0, 0, 0, 0, 0), FloatPoint3D(9, 8, 7));
     chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransformAndEffect;
     simpleTransformAndEffect.transform = simpleTransform.transform;
-    simpleTransformAndEffect.effect = EffectPaintPropertyNode::create(0.5f);
+    simpleTransformAndEffect.effect = EffectPaintPropertyNode::create(nullptr, 0.5f);
     chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransformAndEffect);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransformAndEffectWithUpdatedTransform;
-    simpleTransformAndEffectWithUpdatedTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(1, 1, 0, 0, 0, 0), FloatPoint3D(9, 8, 7));
-    simpleTransformAndEffectWithUpdatedTransform.effect = EffectPaintPropertyNode::create(simpleTransformAndEffect.effect->opacity());
+    simpleTransformAndEffectWithUpdatedTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(1, 1, 0, 0, 0, 0), FloatPoint3D(9, 8, 7));
+    simpleTransformAndEffectWithUpdatedTransform.effect = EffectPaintPropertyNode::create(nullptr, simpleTransformAndEffect.effect->opacity());
     chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransformAndEffectWithUpdatedTransform);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     // Test that going back to a previous chunk property still creates a new chunk.
     chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransformAndEffect);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
     EXPECT_THAT(chunks, ElementsAre(
         PaintChunk(0, 1, nullptr, rootPaintChunkProperties()),
         PaintChunk(1, 3, nullptr, simpleTransform),
         PaintChunk(3, 5, nullptr, simpleTransformAndEffect),
         PaintChunk(5, 7, nullptr, simpleTransformAndEffectWithUpdatedTransform),
         PaintChunk(7, 9, nullptr, simpleTransformAndEffect)));
 }
 
 TEST_F(PaintChunkerTest, BuildChunksFromNestedTransforms)
 {
     // Test that "nested" transforms linearize using the following
     // sequence of transforms and display items:
     // <root xform>, <paint>, <a xform>, <paint>, <paint>, </a xform>, <paint>, </root xform>
     PaintChunker chunker;
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransform;
-    simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
+    simpleTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
     chunker.updateCurrentPaintChunkProperties(nullptr, simpleTransform);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
     EXPECT_THAT(chunks, ElementsAre(
         PaintChunk(0, 1, nullptr, rootPaintChunkProperties()),
         PaintChunk(1, 3, nullptr, simpleTransform),
         PaintChunk(3, 4, nullptr, rootPaintChunkProperties())));
 }
 
 TEST_F(PaintChunkerTest, ChangingPropertiesWithoutItems)
 {
     // Test that properties can change without display items being generated.
     PaintChunker chunker;
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties firstTransform;
-    firstTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
+    firstTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
     chunker.updateCurrentPaintChunkProperties(nullptr, firstTransform);
 
     PaintChunkProperties secondTransform;
-    secondTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(9, 8, 7, 6, 5, 4), FloatPoint3D(3, 2, 1));
+    secondTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(9, 8, 7, 6, 5, 4), FloatPoint3D(3, 2, 1));
     chunker.updateCurrentPaintChunkProperties(nullptr, secondTransform);
 
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     Vector<PaintChunk> chunks = chunker.releasePaintChunks();
 
     EXPECT_THAT(chunks, ElementsAre(
         PaintChunk(0, 1, nullptr, rootPaintChunkProperties()),
         PaintChunk(1, 2, nullptr, secondTransform)));
 }
 
@@ skipping 37 matching lines @@
     PaintChunker chunker;
     TestDisplayItem i1(DisplayItem::DrawingFirst);
     DisplayItem::Id id1 = i1.getId();
     TestDisplayItemRequiringSeparateChunk i2;
     DisplayItem::Id id2 = i2.getId();
 
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransform;
-    simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
+    simpleTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
     chunker.updateCurrentPaintChunkProperties(&id1, simpleTransform);
 
     chunker.incrementDisplayItemIndex(i1);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(i2);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
@@ skipping 12 matching lines @@
     TestDisplayItem i1(DisplayItem::DrawingFirst);
     i1.setSkippedCache();
     DisplayItem::Id id1 = i1.getId();
     TestDisplayItemRequiringSeparateChunk i2;
     i2.setSkippedCache();
 
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     PaintChunkProperties simpleTransform;
-    simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
+    simpleTransform.transform = TransformPaintPropertyNode::create(nullptr, TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));
     chunker.updateCurrentPaintChunkProperties(&id1, simpleTransform);
 
     chunker.incrementDisplayItemIndex(i1);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
     chunker.incrementDisplayItemIndex(i2);
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     chunker.updateCurrentPaintChunkProperties(nullptr, rootPaintChunkProperties());
     chunker.incrementDisplayItemIndex(NormalTestDisplayItem());
 
     Vector<PaintChunk> chunks = chunker.releasePaintChunks();
     EXPECT_THAT(chunks, ElementsAre(
         PaintChunk(0, 2, nullptr, rootPaintChunkProperties()),
         PaintChunk(2, 4, nullptr, simpleTransform),
         PaintChunk(4, 5, nullptr, simpleTransform),
         PaintChunk(5, 6, nullptr, simpleTransform),
         PaintChunk(6, 7, nullptr, rootPaintChunkProperties())));
 }
 
 #endif
 
 } // namespace
 } // namespace blink